Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created Dockerfile #116

Closed
wants to merge 1 commit into from

Conversation

MADscientist314
Copy link

I created a Docker file for launching a docker container using the bioconduction parent rstudio-server image and has mia and miaViz preinstalled via Bioconductor.

@FelixErnst
Copy link
Contributor

FelixErnst commented Jul 19, 2021

@MADscientist314 Thanks for the PR!

However, this is out of scope for this repository. We don't want to push anything non-R related to Bioconductor, which would be the case with the dockerfile.

You can create your own repo, add a good documentation via README.md and maintain the dockerfile there. @antagomir or @microsud can migrate it to the microbiome namespace, if they would like to.

@FelixErnst FelixErnst closed this Jul 19, 2021
@MADscientist314
Copy link
Author

Makes perfect sense. Thanks!

@antagomir
Copy link
Member

Great, thanks!

We can transfer and maintain this as a separate repository under the microbiome organization if you like, and this would make a lot of sense i.m.o. Could be also documented in the online manual.

@antagomir antagomir reopened this Jul 19, 2021
@antagomir antagomir closed this Jul 19, 2021
@antagomir antagomir reopened this Aug 11, 2021
@antagomir
Copy link
Member

Hi @MADscientist314 - we could add this in a separate repository under the microbiome organization. I could create one, and provide the necessary permissions; then we can see how to integrate this into the full workflows.

@MADscientist314
Copy link
Author

@antagomir whatever is easiest for you I am happy to contribute!

@antagomir
Copy link
Member

antagomir commented Aug 13, 2021

Excellent. I just created a repository microbiome/docker and gave you developer-level permissions to that one.

Could you add the container in that repository, and provide the relevant information in README.md - after this let us know, we can review the contents and discuss adjustments through the issues of that repository.

Would this work, @MADscientist314 ?

@antagomir antagomir closed this Aug 13, 2021
@antagomir
Copy link
Member

I have now also cross-checked that @MADscientist314 has the necessary permissions to manage the docker repository. The invitation pending.

@antagomir antagomir mentioned this pull request Sep 9, 2021
@antagomir
Copy link
Member

Ok the discussion continues in the Docker repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants