-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename importers to standardize "import" terminology #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SImilarly to other functions, add the olds function to deprecate.R
Also, I am thinking if importHumann and importMetaphlan should be importHUMAnN and importMetaPhlAn @antagomir
I think we should follow their naming convention even though it is harder to remember the correct naming. It is more clear that the function imports the HUMAnN data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have run devtools::document()
It seems that yu have changed the name of importHUMAnN document but the file name is not updated in man folder
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #505 +/- ##
========================================
Coverage ? 72.82%
========================================
Files ? 40
Lines ? 4648
Branches ? 0
========================================
Hits ? 3385
Misses ? 1263
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Merge branch 'devel' of https://github.com/microbiome/mia into import_functions # Conflicts: # NEWS # R/importMetaphlan.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change loadFromQZA to readQZA, then good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to me when the above points are resolved. |
rename following importers :
loadFromBiom --> importBIOM
loadFromQIIME2 --> importQIIME2
readQZA --> importQZA
loadfromMothur --> importMothur
loadFromMetaphlan --> importMetaphlan
loadFromHumann --> importHumann