Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new generic function agglomerateByVariable #507

Merged
merged 28 commits into from
May 8, 2024
Merged

Conversation

thpralas
Copy link
Collaborator

Create a new generic function agglomerateByVariable to replace the methods mergeCols and mergeRows.
agglomerateByVariable takes parameter MARGIN to specify wether to run mergeCols or mergeRows

R/agglomerate.R Outdated Show resolved Hide resolved
R/deprecate.R Outdated Show resolved Hide resolved
R/agglomerate.R Outdated Show resolved Hide resolved
@TuomasBorman
Copy link
Contributor

Check those comments. I think this looks good

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 42.06349% with 73 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (devel@989206b). Click here to learn what that means.

❗ Current head 35f6660 differs from pull request most recent head 60a79d8. Consider uploading reports for the commit 60a79d8 to get more accurate results

Files Patch % Lines
R/deprecate.R 11.11% 48 Missing ⚠️
R/merge.R 52.38% 20 Missing ⚠️
R/agglomerate.R 80.76% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             devel     #507   +/-   ##
========================================
  Coverage         ?   72.40%           
========================================
  Files            ?       40           
  Lines            ?     4678           
  Branches         ?        0           
========================================
  Hits             ?     3387           
  Misses           ?     1291           
  Partials         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/agglomerate.R Outdated Show resolved Hide resolved
Merge branch 'devel' of https://github.com/microbiome/mia into agglomerateByVariable

# Conflicts:
#	NEWS
#	R/deprecate.R
#	man/deprecate.Rd
Merge branch 'devel' of https://github.com/microbiome/mia into agglomerateByVariable

# Conflicts:
#	NEWS
Merge branch 'devel' of https://github.com/microbiome/mia into agglomerateByVariable

# Conflicts:
#	DESCRIPTION
#	NEWS
#	R/agglomerate.R
#	R/deprecate.R
#	man/agglomerate-methods.Rd
#	man/deprecate.Rd
@antagomir
Copy link
Member

Seems good! Conflicts to be resolved

Sync

# Conflicts:
#	NEWS
#	R/deprecate.R
#	man/deprecate.Rd
@TuomasBorman TuomasBorman merged commit 13f7dce into devel May 8, 2024
1 of 3 checks passed
@TuomasBorman TuomasBorman deleted the agglomerateByVariable branch May 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants