Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate f in favor of group #638

Merged
merged 15 commits into from
Oct 1, 2024
Merged

deprecate f in favor of group #638

merged 15 commits into from
Oct 1, 2024

Conversation

Daenarys8
Copy link
Collaborator

ping #636

Daenarys8 and others added 4 commits September 11, 2024 09:16
Signed-off-by: Daena Rys <rysdaena8@gmail.com>
Signed-off-by: Daena Rys <rysdaena8@gmail.com>
Signed-off-by: Daena Rys <rysdaena8@gmail.com>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 79.50820% with 25 lines in your changes missing coverage. Please review.

Please upload report for BASE (devel@3f3b968). Learn more about missing BASE report.

Files with missing lines Patch % Lines
R/merge.R 64.10% 14 Missing ⚠️
R/calculateJSD.R 0.00% 3 Missing ⚠️
R/getPrevalence.R 80.00% 3 Missing ⚠️
R/splitOn.R 90.00% 3 Missing ⚠️
R/getDominant.R 87.50% 1 Missing ⚠️
R/utils.R 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             devel     #638   +/-   ##
========================================
  Coverage         ?   67.66%           
========================================
  Files            ?       44           
  Lines            ?     5362           
  Branches         ?        0           
========================================
  Hits             ?     3628           
  Misses           ?     1734           
  Partials         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/agglomerate.R Outdated Show resolved Hide resolved
R/calculateJSD.R Outdated Show resolved Hide resolved
R/estimateEvenness.R Outdated Show resolved Hide resolved
R/getDominant.R Outdated Show resolved Hide resolved
R/getPrevalence.R Outdated Show resolved Hide resolved
R/getPrevalence.R Outdated Show resolved Hide resolved
R/getPrevalence.R Outdated Show resolved Hide resolved
R/merge.R Outdated Show resolved Hide resolved
R/splitOn.R Outdated Show resolved Hide resolved
R/taxonomy.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
Copy link
Contributor

@TuomasBorman TuomasBorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments. It seems that you have searched and replaced f with group.

@TuomasBorman
Copy link
Contributor

  • getDominant: group parameter for specifying the grouping used in merging. Merging is done before determining the dominant features. Agglomerating can be done for both taxonomy ranks (more common, agglomerateByRank() is utilized) or other variables (agglomerateByVariable() is utilized). (rank is deprecated)
  • agglomerateByVariable: group parameter for specifying the grouping used in merging. Merging is meant to be done only for variables that are not taxonomy groups. (f is deprecated)
  • splitOn: group parameter for specifying the grouping used in splitting. Splitting can be done for both taxonomy groups or other groups (more common). (f is deprecated)

@TuomasBorman TuomasBorman merged commit 8cace1b into devel Oct 1, 2024
3 checks passed
@TuomasBorman TuomasBorman deleted the fgroup branch October 1, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants