Implement migrator that consolidates PlannedProcess grandchild collections
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbomam
approved these changes
Jun 6, 2024
|
Looks good to me, but I don't have the ability to check it on Mongo, so I just checked the logic as best I could. |
kheal
approved these changes
Jun 7, 2024
|
Thanks, @kheal. The part I typically struggle with is translating a schema change into requirements for a migrator. Knowing that the logic looked OK to you was reassuring to me. |
eecavanna
deleted the
2045-berkeley-schema-fy24-implement-migrator-that-merges-some-collections
branch
eecavanna
commented
Jun 17, 2024
| "metatranscriptome_assembly_set", | ||
| "metatranscriptome_annotation_set", | ||
| "metatranscriptome_analysis_set", | ||
| "mags_analysis_set", |
There was a problem hiding this comment.
The collection's name is mags_set, not mags_analysis_set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I implemented a migrator that accommodates the schema changes made in PR #195.
This migrator deals with collections representing grandchild classes and child classes of the
PlannedProcessclass. For each child class, this migrator moves all documents from the collections representing that child's child classes (i.e. the grandchild classes of thePlannedProcessclass) into their "parent" collection (i.e. the collection representing the child class of thePlannedProcessclass); then, deletes those "grandchild" collections.This migrator creates a collection for each "parent" class (there are 7 of them). Whether that collection will contain any documents depends upon whether it or any of its "child" collections contain any when this migrator is run.
This migrator was designed to run after all currently-implemented migrators run (as indicated by its name, it was designed to run on a database that has been migrated "to PR104" already).
Merging this PR branch will fix microbiomedata#2045.