fix(validation): allow any valid nmdc:Database to [/v1]/workflows/activities #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivities Documents other than activities may be generated and submittable at the same time. closes #462
aclum
approved these changes
Mar 15, 2024
shreddd
reviewed
Mar 15, 2024
| @@ -78,10 +80,6 @@ async def post_activity( | |||
| """ | |||
| _ = site # must be authenticated | |||
| try: | |||
| # verify activities in activity_set are nmdc-schema compliant | |||
There was a problem hiding this comment.
Do we still want to perform this check for certain kinds of activtities rather than dropping entirely
There was a problem hiding this comment.
If another kind of record down the road other than data objects are desirable to bundle with an activities submission, I don’t see a benefit to gating that here. So, I’d rather make its acceptable input equivalent to that of /metadata/json:submit.
shreddd
reviewed
Mar 15, 2024
| @@ -46,10 +46,6 @@ async def post_activity( | |||
| """ | |||
| _ = site # must be authenticated | |||
| try: | |||
| # verify activities in activity_set are nmdc-schema compliant | |||
There was a problem hiding this comment.
Do we still want to perform this check for certain kinds of activtities rather than dropping entirely
|
PS. No need to block on my comments - mostly just checking |
PeopleMakeCulture
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents other than activities may be generated and submittable at the same time.
closes #462