Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5: convert dates to ISO-8601 format #6

Merged
merged 5 commits into from
May 25, 2021
Merged

Issue 5: convert dates to ISO-8601 format #6

merged 5 commits into from
May 25, 2021

Conversation

wdduncan
Copy link
Contributor

See #5

@dwinston
Copy link
Collaborator

This still needs code added, right? Or is the PR intended to simply be an addition of example json files?

@wdduncan
Copy link
Contributor Author

@dwinston I've added the code to change the add_date and mod_date fields to iso-8601 format. I've also added the nmdc_database.json.zip that is the output of the make run-etl target. I wasn't sure if needed to re-run make run-elt to incorporate the new data or if you could slurp in the zip file.

@dwinston dwinston merged commit a7914d1 into main May 25, 2021
@wdduncan wdduncan deleted the issue-5 branch May 26, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants