Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write tests about assets/misc/neon_nmdc_term_mapping.tsv divergence from schema #1703

Open
turbomam opened this issue Jan 23, 2024 · 4 comments
Assignees

Comments

@turbomam
Copy link
Member

turbomam commented Jan 23, 2024

assets/misc/neon_nmdc_term_mapping.tsv is still mentioning quality_control_report.status, which will be removed in the pending release

We shouldn't have any artifacts that mention patterns that are illegal in the released schema

  • What is the role of assets/misc/neon_nmdc_term_mapping.tsv?
  • Is it being programmatically accessed?
    • UPDATE: No, @sujaypatil96 uses files like these as inspiration for writing code with hard-coded configurations
    • UPDATE: It's hard to believe that a TSV file would ever provide the required flexibility and expressiveness
  • Are there any related files that might be getting stale in the same way?
@turbomam
Copy link
Member Author

turbomam commented Jan 23, 2024

Mark could write tests (that generate warnings, not failures) over the mapping files, but that will only check if nmdc-schema paths still exist, not if the mappings are proper.

Could just add a README to the mappings directory

@turbomam
Copy link
Member Author

depth mapping is interesting too

depth source would ideally be lakeSampleDepth1 etc. but there is a lots of inter-field dependency here

TLDR flat file doesn't really capture the mapping!

@turbomam
Copy link
Member Author

@turbomam turbomam changed the title It doesn't look like assets/misc/neon_nmdc_term_mapping.tsv is being maintained with respect to schema changes write tests about assets/misc/neon_nmdc_term_mapping.tsv divergence from schema Jan 23, 2024
@turbomam
Copy link
Member Author

long term: could use linkml-transformer

@turbomam turbomam assigned turbomam and unassigned aclum, sujaypatil96 and mslarae13 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants