-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elevation should be required in the soil template #120
Comments
OK, I need to set it's LinkML For which environments should it be required? Should I just check with MIxS :-) ? I'm confused about why it's in the MIxS modified section already... nothing has been modified. I think that section membership is declared in the Google Sheet now instead of being detected by inspection. |
Confirming that |
Check sheets and friends elevation is required in modifications long & this slot is required in the submission portal. |
I am confirming that |
https://github.com/microbiomedata/submission-schema/blob/main/src/data/valid/SampleData-soil-data-exhaustive.yaml contains two
Both have Note the absence of any units. We should ensure that this column is entitled "elevation in meters". @cmungall has some long term solutions so we won't have to manually manage slot names, title and validation rules, esp. with regards to measurements that have explicit or implicit units. That file is converted into https://github.com/microbiomedata/submission-schema/blob/main/examples/output/SampleData-soil-data-exhaustive.json by the the examples/output/README.md Makefile target. If it were invalid to assign an |
I also created
This demonstrates that @sujaypatil96 @pkalita-lbl and I can help colleagues create valid and invalid test files like these to check their expectations |
For reference, see DH link - admin privileges required.
Elevation is required in the MIxS soil package (confirmed in v6). During the GSP workshop, we demo'd it as required (see last page of solutions for attendees). Currently, validation only flags entries with missing units, but does not flag empty cells.
The text was updated successfully, but these errors were encountered: