Skip to content

A11y: Table tds not selectable. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

microbit-carlos
Copy link

Removing the td field from the querySelector, and converting the snippet triggers into a link.

@microbit-mark
Copy link
Owner

Tested in Chrome and Safari, but this breaks snippets in Firefox. Not sure why. TBH tabbing doesn;t work propery in FF anyway

@microbit-carlos
Copy link
Author

Okay, converting the anchors into buttons should take advantage of the browser default A11y features, which is much better in general anyway.
I'm hoping this version works in all browsers.

@microbit-mark
Copy link
Owner

microbit-mark commented Oct 31, 2019

If we can use <button> then we also don't need the extra JS to check for enter/space key presses as it's built into <button>. I'll merge this and update my branch. Thanks 😄

@microbit-mark microbit-mark merged commit 482d577 into microbit-mark:a11y-modal-focus Oct 31, 2019
@microbit-carlos microbit-carlos deleted the a11y-modal-focus-update branch October 31, 2019 10:28
@microbit-carlos
Copy link
Author

If we can use then we also don't need the extra JS to check for enter/space key presses as it's built into .

I think in this case the JS is there to enable the click anywhere in the table row, so if it still works correctly with the button I would probably leave as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants