Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AppInvite and Firebase DynamicLinks #999

Closed
alexandruchircu opened this issue Jan 1, 2020 · 8 comments
Closed

Implement AppInvite and Firebase DynamicLinks #999

alexandruchircu opened this issue Jan 1, 2020 · 8 comments

Comments

@alexandruchircu
Copy link
Contributor

Some apps complain and some apps crash because of missing AppInvite/DynamicLinks.

Pull requests incoming on GmsApi, GmsLib, GmsCore.

@arnauvp
Copy link

arnauvp commented Mar 23, 2020

@mar-v-in @ale5000-git @benwaffle we found these fixes prevented a few apps from crashing.
Do you need anything else in order to get them integrated? If you can no longer afford maintaining these projects, we (the e.foundation) wouldn't mind giving a hand until you have more time to come back to it.

@sam-public
Copy link

@mar-v-in Any progress on merging these changes? Multiple apps are breaking with firebase.

@mar-v-in
Copy link
Member

mar-v-in commented Jul 9, 2020

@alexandruchircu @arnauvp can you point to some apps affected by this for testing please?

@dicer
Copy link
Contributor

dicer commented Jul 9, 2020 via email

@alexandruchircu
Copy link
Contributor Author

fr.doctolib.www is the app that led to this being implemented.

@dicer
Copy link
Contributor

dicer commented Jul 5, 2022

@mar-v-in Could we get this merged please? Just stumbled upon it again in one of my apps (can't share the usecase unfortunately, cause it contains private data in the link etc).

@mar-v-in
Copy link
Member

mar-v-in commented Jul 5, 2022

This is essentially implemented.
Feel free to send email to microg at larma.de if you don't want to make your issue public for privacy reasons.

@mar-v-in mar-v-in closed this as completed Jul 5, 2022
@dicer
Copy link
Contributor

dicer commented Jul 5, 2022

Yeah, sorry, just realized that 2 of the 3 merge requests were merged and I see the appropriate debug messages in the log. Will analyze further and get back to you directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants