-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AppInvite and Firebase DynamicLinks #999
Comments
@mar-v-in @ale5000-git @benwaffle we found these fixes prevented a few apps from crashing. |
@mar-v-in Any progress on merging these changes? Multiple apps are breaking with firebase. |
@alexandruchircu @arnauvp can you point to some apps affected by this for testing please? |
mobile.santander.de.smartsign crashes on startup for me.
*Without* the pull request applied! Haven't tested with it
|
fr.doctolib.www is the app that led to this being implemented. |
@mar-v-in Could we get this merged please? Just stumbled upon it again in one of my apps (can't share the usecase unfortunately, cause it contains private data in the link etc). |
This is essentially implemented. |
Yeah, sorry, just realized that 2 of the 3 merge requests were merged and I see the appropriate debug messages in the log. Will analyze further and get back to you directly. |
Some apps complain and some apps crash because of missing AppInvite/DynamicLinks.
Pull requests incoming on GmsApi, GmsLib, GmsCore.
The text was updated successfully, but these errors were encountered: