Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polish translations #1876

Closed
wants to merge 16 commits into from
Closed

Conversation

SpacingBat3
Copy link
Contributor

@SpacingBat3 SpacingBat3 commented Jan 29, 2023

Things in scope of this PR:

  • Add missing strings.

I localized some recently added strings to microG to Polish.

  • Sync license comment in play-services-core -> strings.xml.

I removed full license notice and replaced it with the newer ones from original values in strings.xml (only play-services-core, I believe others had them OK, at least when comparing with original values).

  • Minor tweaks.

Some grammar fixes, alternative localizations that I find more accurate to the original or more appropriate for the language etc.

Things currently not in scope for this PR:

Since most of these weren't localized a long time ago, I'm not sure if it is desired to localize components name, considering most of them are not localized for any language.

Nightly builds:

There are nightly builds available, both unsigned and signed by GitHub Actions using key generated by me, distributed as artifacts of following actions runs. Note: you need to sign in to GitHub in order to download artifacts.

@SpacingBat3
Copy link
Contributor Author

SpacingBat3 commented Jan 29, 2023

Actually I haven't noticed #1377, closing this PR (sorry)…

@SpacingBat3
Copy link
Contributor Author

Actually I haven't noticed #1377, closing this PR (sorry)…

Oh, I see this PR is based on old sources, I might again work on this PR and localize another files that I haven't looked at yet. I might also resolve conflicts and sync my fork with the upstream for some time.

@SpacingBat3 SpacingBat3 reopened this Jan 30, 2023
@SpacingBat3 SpacingBat3 marked this pull request as draft January 30, 2023 19:53
@SpacingBat3 SpacingBat3 marked this pull request as ready for review January 30, 2023 22:35
@SpacingBat3
Copy link
Contributor Author

SpacingBat3 commented Jan 30, 2023

I hope I've caught all values now, I used this command to find all **/values/ within the project (then I manually checked which seemed to be translatable):

find -type d -name "values"

In contrast to PR #1377, this PR also contains recent FIDO and has been made from scratch, so there might be some slight differences within the used words, although meaning should be similar (I've tried to picked synonyms that sound more natural in Polish rather these words which look and sound more closely to the original ones in values/).

For tests with prebuilt app, I dunno… maybe I'll try build microG from sources and check how that works either in Android emulator or on real device if I'll find some time for that.

@Wojtaz0w
Copy link

Wojtaz0w commented Feb 3, 2023

play-services-nearby/core/src/main/res/values-pl/strings.xml
Fix line 44 please
I would translate to "Eksportuj zebrane ID w celu roszerzonej analizy inną aplikacją"

@SpacingBat3
Copy link
Contributor Author

SpacingBat3 commented Feb 4, 2023

@Wojtaz0w thanks for noticing that, I translated it a bit differently (I used "dla" instead of "w celu" and added "poprzez" pronoun, which I think makes it to look and sound more naturally – not sure if you agree with that, I guess it might be more a personal thing). I've also made you a co-author of this commit, I dunno if I would notice that string without you, so I wanted to give you some attribution as well 🙂️.

I also want fix quotes in current Polish microG translations (in play-services-core), these use single upper quote marks ( and ) where it would be more appropriate in Polish to use a combination of double lower and upper marks instead ( and ). I originally wanted to left it untouched, but given I use double quotes in another locale files, it might be a good idea to make them consistent across different files.

@SpacingBat3
Copy link
Contributor Author

Also check microg/UnifiedNlp#249.

@mar-v-in mar-v-in force-pushed the master branch 4 times, most recently from ae17355 to 8078073 Compare April 20, 2023 08:25
@SpacingBat3 SpacingBat3 force-pushed the master branch 2 times, most recently from 622f221 to 3a671f6 Compare May 29, 2023 22:09
SpacingBat3 and others added 4 commits May 31, 2023 23:46
- Add missing strings.
- Sync license comment in `strings.xml` in `core`.
- Minior tweaks.
Co-authored-by: Wojtaz0w <104674625+Wojtaz0w@users.noreply.github.com>
The double quotes are more appropriate for Polish language and should be
preferred over English upper single quotes.
Localize `values` for new location stack.
@SpacingBat3
Copy link
Contributor Author

With values-pl added for the new location stack, this PR should be ready to be merged now. Does it LGTM or anyone has spotted some typos or errors?

@Wojtaz0w
Copy link

Wojtaz0w commented Jun 1, 2023

Line 16 in commit d6a3f37 (new location settings translation) is partially translated, also "Mozilly" should be replaced with "Mozilli" (według mnie w dopełniaczu powinno mówić się mozilli a nie mozilly)

(wiem że ss z 2006 ale język nie zmienia się tak szybko 😉)
Screenshot_20230601-080851_Firefox Nightly.png

@SpacingBat3
Copy link
Contributor Author

Line 16 in commit d6a3f37 (new location settings translation) is partially translated, also "Mozilly" should be replaced with "Mozilli" (według mnie w dopełniaczu powinno mówić się mozilli a nie mozilly)

Sounds right to me! Funilly enough, I've been checking mozilla.org for tips on localization and somehow still didn't payed attention to how it is there. Thanks a lot again!

• Translate parts of `strings.xml` that weren't fully translated before.
• Typo fixes and improvements.

Co-authored-by: Wojtaz0w <104674625+Wojtaz0w@users.noreply.github.com>
@SpacingBat3
Copy link
Contributor Author

I've updated translations according to your comment, I think nothing else is going to be improved for now and this PR is finally ready to be merged.

@SpacingBat3 SpacingBat3 deleted the upstream-merge branch August 30, 2023 13:43
@SpacingBat3 SpacingBat3 restored the upstream-merge branch August 30, 2023 13:44
@SpacingBat3 SpacingBat3 reopened this Aug 30, 2023
@SpacingBat3
Copy link
Contributor Author

OK, I've updated translation for new strings, possibly I'll give it a try and build microG (again) to see if I haven't left anything (+ it's going to be interesting to test how new localization API works). I guess it's now ready for reviews (especially from microG maintainers)…
Also, anyone cares about me setting GitHub Actions for nightly builds and Polish translation repo until it gets merged?
And sorry for spamming a bit the PR thread and for somehow renaming the branch, I guess GitHub's web interface is still enigma for me even after I used it for quite a while 😅…

@SpacingBat3 SpacingBat3 marked this pull request as draft September 26, 2023 18:49
@SpacingBat3 SpacingBat3 marked this pull request as ready for review September 26, 2023 20:19
@SpacingBat3
Copy link
Contributor Author

I've set up Actions to build and sign GmsCore in my repo. You can use that to download prebuilt binaries for testing. Take a note those are obviously signed with different key, so you won't be able to update it over existing microG binaries, at least without disabling signature verification when installing apps in Android.

@SpacingBat3
Copy link
Contributor Author

@mar-v-in Pinging in case this PR hasn't been noticed or sth. Feel free to take your time, though, I saw a lot of people were pinging you already and I don't want to give any additional pressure to that. Also I believe I've translated everything I could to Polish for now.

@SpacingBat3
Copy link
Contributor Author

SpacingBat3 commented Oct 28, 2023

Looks like microG is now using Weblate and will accept translations that way (yay!), but I suppose the current work I did stays in conflict with what's in Weblate and most likely won't be accepted (boo?), so I'll probably be closing this PR and eventually contributing the translations via Weblate (it doesn't look like Polish translations are as complete in Weblate as here on my repo, at least just by comparing the conflicting files).

Also, since I've been working on a CI/CD, I might also do some effort to make it upstreamed and made more properly (possibly to not to rely on any external actions).

@SpacingBat3
Copy link
Contributor Author

I've published most of my changes to Weblate, so the translations should now be complete. I suppose this makes this PR stale and it is safe to finally close it.

@Wojtaz0w
Copy link

Guess that pushing translations to weblate finally makes the microG creator notice them... TYSM for hard work.

@SpacingBat3 SpacingBat3 deleted the upstream-merge branch February 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants