Bump com.google.android.gms (fixes #482 #526 #543) #553
Conversation
|
This will probably fix more than just those 3 issues. Is @mar-v-in the only person in this organization who can accept PRs? |
|
@ThibG So have you tested this on an ARMv7 device, and does it actually works for SafetyNet? |
|
@ArchangeGabriel yes. |
| @@ -65,7 +65,7 @@ android { | |||
| versionName getMyVersionName() | |||
| def x = getMyVersionCode() - 367 | |||
| @@ -65,7 +65,7 @@ android { | |||
| versionName getMyVersionName() | |||
| def x = getMyVersionCode() - 367 | |||
| // We are not allowed to freely choose the hundreds column as it defines the device type | |||
| versionCode(12221400 + x % 100 + ((int) (x / 100)) * 1000) | |||
| versionCode(12688000 + x % 100 + ((int) (x / 100)) * 1000) | |||
There was a problem hiding this comment.
// We are not allowed to freely choose the hundreds column as it defines the device type
So shouldn't this be 12688400 then?
There was a problem hiding this comment.
@Roboe Latest versions changed the version code scheme, so that it's no longer required to have version code ending on 4xx.
There was a problem hiding this comment.
Oh, great. Then the comment should be removed, for avoiding mistakes like mine above.
|
This might fix #556 too |
|
Tested this myself, this does fix GBoard (#556) |
|
Yeah, lgtm please |
|
This organization desperately needs more than one maintainer |
Indeed. Meanwhile, we can donate so eventually @mar-v-in and/or a future additional maintainer could dedicate more time to this. Considering the userbase and importance of the project, we can totally fund a decent number of hours of worktime per week. https://liberapay.com/microG/ |
|
Is this linked to the project or the maintainer account? I support work on the project but wouldn't support a maintainer directly if I don't know his future intentions for the project
…On 5 July 2018 11:39:11 GMT+02:00, tuxayo ***@***.***> wrote:
|
|
@pascalwhoop Only the project but there is only one member on the team so it's the same. And any donation now can only motivate to free more time for the project. Or at least it will prepare the ground for other member joining the team. |
|
@mar-v-in Could you please give us an update on maintainer status and if there will be a backup person that can jump in? |
|
I am still their to maintain, but I won't refuse a co-maintainer, in case there is one willing and interested in the constantly changing tech behind GMS. The version bump does not really solve all issues. microG is currently incompatible with this version of GMS. Bumping version will cause additinal issues with push notifications. Unfortunately the fix is quiet some work. |
|
I think at this point this project very much depends on your knowledge @mar-v-in, but as I understand you unfortunately lack the time to actively work on it. (This discussion is however OT, maybe we continue in a separate issue, if you have any further comments and suggestions?) |
|
@mar-v-in |
|
@mar-v-in Happy to see you're still alive :) Are there any resources (besides manually reverse-engineering) you can point us to regarding how that stuff works / what is changing? Besides, I agree on @ale5000-git being a great candidate as a maintainer, he's been helping people out and trying to figure things out actively for some time now :) |
|
Hi, I used docker image to build los for microg 15.1 for klte (armv7) with this repo https://github.com/steamp0rt/android_prebuilts_prebuiltapks/commit/cead122774449960bbd1271e161f884191bdbf0e |
|
@4parthy My pre-built APK is just made to stop things from freaking out about outdated google play services |
|
:face_palm: oh boy there I thought i saw the same changes but it was just the number that was the same. There is probably no way to find those changes in a pre built anyways. Sry for the bump and thanks. Back to building... |
|
So will we see this merged soon? Everyone relying on Apps which requite GCM & stuff can't use those anymore.... >.< |
|
@cRaZy-bisCuiT Hey, that's not true. My apps run even the popup is shown about outdated GMS. I dismiss the popup by clicking beside it and the apps run. It's just annoying but no show stopper. |
|
@cRaZy-bisCuiT Why don't you just downgrade the app that is whining to a version just old enough to not whine? Many devs release app updates way to often anyway. How often do you notice a significant change after an update? I often only update an app when it shows issues and that suits /me, personally/ very well. |
|
Hey guys! For me it's a show stopper since I newly deployed a mobile handset and I don't have old versions/apks left. It doesn't feel convenient to receive those versions from shady sources. In addition: The apps may run, but like e.g. Telegram doesn't use GCM anymore like this and drains massively the battery which is a no-go. If everything would be running I'd freeze updates until the app forces me to update to use the service. In this case, it's not possible. |
|
@cRaZy-bisCuiT You can look at apkmirror or if your app - like Telegram - is also available on F-Droid without gcm libraries. Telegram FOSS is a good alternative. I recommend you backup your /data/app partition by adb backup (including apk's) before switching over to a new phone which makes reinstalling the right apk versions more convenient. |
|
Thanks for the advice of the backup. I've done this before. Unfortunately I have no microG phone to do so atm. In addition, Telegram FOSS is no alternative to me since I have to chose between getting no notifications (battery optimization) or getting notifications but battery drain when letting the app work in background and getting massive wakelogs. It seems like we will have to wait. It's very unfortunate that there's just one maintainer. We really need to step up the game if we want to make people leaving gapps behind. How would be the procedure to apply for being a maintainer? Also: How does the updates from Github find there way to F-Droid / LineageOS for MicroG? |
|
old versions are not illegal and their sources don't need to be very shady. I compare checksums from multiple sources in case of doubt. But hey, running your android without official play services may come to some costs, but this one feels not hard to get by. |
|
@cRaZy-bisCuiT To fix the battery drain, I discovered it helps disabling all gms services in apps which are not supported by the current microg version. No guarantee but for me it worked. Telegram FOSS has a backrgound service and drains my battery < 1% during an hour being on the mobile network. Example from my boot shell script:
|
|
@Catfriend1 Many of these components are repetitive, so you need really not list them over and over like that 😉. This is what I use to disable analytics and ads in all non-system apps: I even have a Firebase related line there (although disabled). You could just add the other components that apply to all apps, and then only separately list those that are app specific. This will still be a rather dirty workaround though, as you never know when the apps change their internals (so you have to keep checking them). |
@Catfriend1 |
|
@bam80 Yes, the settings screen says you have to toggle this on manually if you'd like to get push notifications. |
|
Even if Telegram works, Signal is left behind. Those two my apps rely on GCM in my portfolio. What is the blocker of this pull request not being merged? BTW is it up to date regarding current Play Services version? |
|
@Catfriend1 but who would like using Telegram without notifications? ) |
I had Signal without GCM/MicroG for a month and didn't notice a significant battery drain. |
|
Bump for the bump. May be release this as a beta so people relying on clean 111 build functionality won't be out of luck. |
|
@Catfriend1 Do you mean the functionalities that hasn't changed and is "just" blocked by the version number? What about the functionalities that changed and will behave unexpectedly? Maybe it will just crash and won't work, so nothing worst than today. Or maybe worst. Does anyone know how risky would it be? |
|
@tuxayo we currently don't know if it will be much better or worse nor risky. But spitting out an apk people like me wanting to take the risk and try can report back. Above, some users already told that it feels "good" to bump the version even if implementation is still missing. |
|
Oh right, releasing as beta (or alpha?). I missed that. Good idea! Bug reports will help to understand how the current APIs work. |
|
For instance, all I care about is passing SafetyNet and having working LocationService. So if GCM is broken, that’s fine for me. I don’t have time to look into building an APK with the required changes, but I would test one if provided by someone I trust. |
|
Could you please explain to me once again why it's not possible to NOT hard code this setting and allow to spoof any version just by changing setting. I understand that restarting the core might be necessary.... |
|
The version number isn't a runtime part and build specific. |
|
Done as part of 4040e3d |
As far as I know, this is enough to make SafetyNet pass (as long as the correct droidguard VM is downloaded, which is only the case for ARMv7 devices).
Therefore, this should fix #482 (as well as the duplicates #526 and #543)