Exclude com.bankid.bus from provider installer #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of the ProviderInstallerImpl broke com.bankid.bus (BankID säkerhetsapp). This app is essential to Swedish users since it is effectively the de facto Swedish online id. This issue is resolved by adding the app id to the existing black list. Fixes microg#824
|
Now I am not really a developer nor a very proficient programmer, especially with Java. So if there is anything wrong here feel free to fix it for me. I just thought at the very least I would share my tested and working commit. Hopefully it is of sufficent quality and simple to merge, as it is. |
|
@mar-v-in I understand your time is limited but could you please just do a quick review of this fix? It is a very small 2 line fix that would make all Swedish users very happy. We would all be very grateful. |
|
Thank you @mar-v-in ❤❤✨🌸 |
|
Soo.. Any chance this could make it into a new release as well? 😇😇🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the ProviderInstallerImpl broke com.bankid.bus
(BankID säkerhetsapp). This app is essential to Swedish users since it
is effectively the de facto Swedish online id.
This issue is resolved by adding the app id to the existing black list.
Fixes #824