Support for disabling JavaScript at navigation #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am sorry, I am not writing any tests. |
Kikobeats
reviewed
Dec 28, 2019
packages/goto/src/index.js
Outdated
| } | ||
|
|
||
| if (disableJavaScript) { | ||
| await page.setJavaScriptEnabled(!disableJavaScript) |
There was a problem hiding this comment.
haha just true there is enough 😛
There was a problem hiding this comment.
You are completely right... 😝
But I think it should be false in this case though.
|
@Timkor no problem, it looks good. Do you know any URL for testing this? |
|
@Kikobeats You could send some HTML string with a script, which alters the page, to browserless. And then check if the alternation did not succeed. I think that's the easiest solution for testing. |
|
@Kikobeats Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.