Skip to content

Conversation

Kikobeats
Copy link
Member

No description provided.

@Kikobeats Kikobeats requested a review from remusao February 4, 2020 09:44
@coveralls
Copy link

coveralls commented Feb 4, 2020

Coverage Status

Coverage remained the same at 67.442% when pulling 4478297 on next into 3194a63 on master.

@Kikobeats
Copy link
Member Author

@remusao removed .text() as well and looks the engine.bin is created successfully 🙂

@remusao
Copy link
Collaborator

remusao commented Feb 4, 2020

@remusao removed .text() as well and looks the engine.bin is created successfully slightly_smiling_face

I think it's because the text part is not used, we only need json fetching and binary fetching. So you could probably just remove it... Although we never know, maybe I could change the internals :P

just to be 1:1 with fetch interface
@Kikobeats
Copy link
Member Author

then let's keep it

@Kikobeats Kikobeats merged commit c05bb08 into master Feb 4, 2020
@Kikobeats Kikobeats deleted the next branch February 4, 2020 10:05
@remusao
Copy link
Collaborator

remusao commented Feb 4, 2020

then let's keep it

But then you need to add .text() :P 4478297

@Kikobeats
Copy link
Member Author

Kikobeats commented Feb 4, 2020

I mantained got(url) instead of got(url).text() since gotuses text by default as serializer

@remusao
Copy link
Collaborator

remusao commented Feb 4, 2020

I mantained got(url) instead of got(url).text() since gotuses text by default as serializer

That makes sense, I did not know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants