Skip to content
This repository has been archived by the owner on Oct 15, 2021. It is now read-only.

Bootstrap Kickstart 4.0 #127

Closed
34 tasks done
mischah opened this issue Apr 19, 2017 · 9 comments
Closed
34 tasks done

Bootstrap Kickstart 4.0 #127

mischah opened this issue Apr 19, 2017 · 9 comments

Comments

@mischah
Copy link
Member

mischah commented Apr 19, 2017

Roadmap for the next major release:

Working branch is v4-dev. Features should be implemented by creating feature branches and pull requests.

Basics (Prio 1)

  • Replace Grunt with Gulp (4 Beta)
    • Update README
      • Changelog conventions
      • Replace Grunt with Gulp
      • Info regarding unit tests (watching) and coverage with Jest
    • Dev-Workflow (optional with watching)
      • Module bundling
        • Creating two bundles like before (own code / Vendor)
        • Rollup, Fuse-Box?!?
      • ES6 Transpiling (via Babel)
      • Linting
        • shouldn’t crash build
        • should run async (own pipe)
      • LESS Transpiling
        • Auto prefixing via LESS plugin
      • Dev Server
        • Browsersync
      • HTML Lint
      • Bootlint
      • Watch
      • Copy static files from node_modules to libs
      • Bundle external CSS to libs/libs.min.css
    • Production-Workflow
      • Exchange references to minified CSS/JS in HTML (processHTML)
      • Image Optimizing
      • Minify CSS via LESS transpiling
      • Minify JS via uglify
      • UnCSS
      • Serve build directory
      • NSP
    • Release Workflow
  • Sass instead of LESS (even with Bootstrap 3.x)

Nice to have (Prio 2)

  • Dev-Workflow
    • Handlebars mit Frontmatterns und Templates und Partials
  • Production-Workflow
    • HTML minify (strip comments)
    • Unit Tests (mit Coverage) via Jest
    • Cachebusting
  • Release Workflow

Ideas / to discuss (Prio 3)

@mischah mischah added the v2 label Apr 19, 2017
@mischah mischah added this to the 4.0 milestone Apr 19, 2017
@mischah mischah mentioned this issue Apr 24, 2017
@mischah
Copy link
Member Author

mischah commented Apr 26, 2017

Question: Do we need JSDoc?

I don’t think so.
Okay. We are using JSDoc conventions for docBlock comments. But did we ever used generated docs in the past?

JSDocs make sense for generating API docs. But that’s not our use case with Bootstrap Kickstart.

Can I get a 👍 or 👎 for dropping JSDoc?

@krnlde @revrng cc/ @micromata/ux

@krnlde
Copy link
Contributor

krnlde commented Apr 26, 2017

I prefer to read the docblock comments in the code itself rather than in a static, unsearchable documentation.

@mischah
Copy link
Member Author

mischah commented Apr 27, 2017

Removed JSDoc checkbox for now.
Willing to bring it back if someone desperately needs it.

@mischah
Copy link
Member Author

mischah commented Apr 27, 2017

Generating a changelog with »conventional changelog« using the Angular preset is now set up in the v4-dev branch.

You should write your commit messages with this conventions in mind.

Short summary of the conventions

Example commit message:

fix(uglify): Remove console output and debugger statements

Consists of:

type(scope): subject

Types

Types are used to group commits in the changelog.
Possible types which are rendered in the changelog are: feat, fix and perf.

There are additional ones which you can use. But these are only rendered if they introduce a breaking change:
docs, chore, style, refactor, and test.

Scope

The scope is optional and you can choose from whatever you want.
The scope is used as another grouping element below the type.

You can skip the parentheses if you don’t want to use Scope:

style: Fix linting errors 

Subject

The subject contains succinct description of the change:

  • use the imperative, present tense: "change" not "changed" nor "changes"
  • capitalize first letter
  • no dot (.) at the end

Additional Info, Breaking changes and issue references

Are defined in the body of the commit message.

Example:

feat(build): Replace Grunt with Gulp
<BLANK LINE>
Closes #28
BREAKING CHANGE: Grunt Tasks aren’t available any longer.
But there are equvalent Gulp tasks. 
List the available tasks with `gulp --tasks`

The body can include the motivation for the change and contrast this with previous behavior.

Plus it should contain any information about Breaking Changes and is also the place to
reference GitHub issues that this commit Closes.

Breaking Changes should start with the word BREAKING CHANGE: with a space or two newlines. The rest of the commit message is then used for this.

Generated Changelog

This is how a changelog based on this conventions is rendered:
https://github.com/angular/angular/blob/master/CHANGELOG.md


See the last few commits of the v4-dev for some real life examples: https://github.com/micromata/bootstrap-kickstart/commits/v4-dev

mischah added a commit that referenced this issue Apr 28, 2017
I’m not sure if we bring back the whole feature set of generating static sites with handlebars, templates, partials and frontmatters with v4.

See #127

But this can easily be reverted in case we have a proper solution.
@mischah mischah mentioned this issue Apr 28, 2017
mischah added a commit that referenced this issue May 1, 2017
I’m not sure if we bring back the whole feature set of generating static sites with handlebars, templates, partials and frontmatters with v4.

See #127

But this can easily be reverted in case we have a proper solution.
@mischah
Copy link
Member Author

mischah commented May 1, 2017

I’ve released 4.0.0-beta.0 🎉

Let’s discuss what else we need to release v4 and what we could ship with a later release …

@mischah
Copy link
Member Author

mischah commented May 5, 2017

We won’t bring back ESLints fix option. See #164 for details. Thanks @krnlde for his valuable feedback.

@mischah
Copy link
Member Author

mischah commented May 16, 2017

I’ve released 4.0.0-rc.0 🎉

Can I haz sum feedback regarding #166?

Another question: Do you think we should add information how to change ESLint and Stylelint settings to the README?

@mischah
Copy link
Member Author

mischah commented Jun 2, 2017

Just made switched back the default branch to master in preparation for the release.
Related to #183

Make sure you switch to the correct target branch in case in case you open another PR for v4.

@mischah
Copy link
Member Author

mischah commented Jun 16, 2017

It’s done 🎉

https://github.com/micromata/baumeister/releases

@mischah mischah closed this as completed Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants