Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update managed.logback to v1.5.3 #94

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 16, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ch.qos.logback:logback-core (source, changelog) 1.4.14 -> 1.5.3 age adoption passing confidence
ch.qos.logback:logback-classic (source, changelog) 1.4.14 -> 1.5.3 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: dependency-upgrade Upgrade a dependency label Feb 16, 2024
@renovate renovate bot changed the title Update managed.logback to v1.5.0 Update managed.logback to v1.5.1 Feb 28, 2024
@wetted
Copy link
Contributor

wetted commented Feb 29, 2024

ping @sdelamo @timyates

This PR is broken because there is no ch.qos.logback:logback-access for v1.5.x (1.4.14 is latest). That has been moved to it's own repo and a release is planned for March '24. See qos-ch/logback-access#1 and https://logback.qos.ch/news.html

We will need to add a new version to the catalog for managed-logback-access independent of managed-logback. It will also have a new groupId of ch.qos.logback.access but I think we need to wait to do anything until it is released.

@timyates
Copy link
Contributor

timyates commented Mar 1, 2024

Can we add a new managed-logback-access version which can stay on 1.4.14 for now?

Does 1.4.14 of access work with 1.5.1 of logback?

Looks like access is only a servlet thing? Have we tried it? I don't think we have any tests for it 🤔

@wetted
Copy link
Contributor

wetted commented Mar 1, 2024

Can we add a new managed-logback-access version which can stay on 1.4.14 for now?

Does 1.4.14 of access work with 1.5.1 of logback?

Looks like access is only a servlet thing? Have we tried it? I don't think we have any tests for it 🤔

See qos-ch/logback-access#1 (comment) where it's noted that logback-access is generally copied into the servlet container. Given that, maybe we should bump the minor for micronaut-logging and add a managed-logback-acess (once it's released....this month?). Maybe we should bump the major for Micronaut 5 and remove it altogether? 🤷‍♂️

@timyates
Copy link
Contributor

timyates commented Mar 1, 2024

We also support embedded tomcat/jetty/etc... And I'm not sure what happens there 🤔

@renovate renovate bot force-pushed the renovate/managed.logback branch from 3e077a2 to a3537cf Compare March 2, 2024 22:06
@renovate renovate bot changed the title Update managed.logback to v1.5.1 Update managed.logback to v1.5.2 Mar 2, 2024
@renovate renovate bot changed the title Update managed.logback to v1.5.2 Update managed.logback to v1.5.3 Mar 4, 2024
@renovate renovate bot force-pushed the renovate/managed.logback branch from a3537cf to f42ce52 Compare March 4, 2024 15:59
@sdelamo
Copy link
Contributor

sdelamo commented Mar 4, 2024

Can we add a new managed-logback-access version which can stay on 1.4.14 for now?
Does 1.4.14 of access work with 1.5.1 of logback?
Looks like access is only a servlet thing? Have we tried it? I don't think we have any tests for it 🤔

See qos-ch/logback-access#1 (comment) where it's noted that logback-access is generally copied into the servlet container. Given that, maybe we should bump the minor for micronaut-logging and add a managed-logback-acess (once it's released....this month?). Maybe we should bump the major for Micronaut 5 and remove it altogether? 🤷‍♂️

@wetted do as @timyates suggest. master already uses the next minor 1.3.0

@sdelamo
Copy link
Contributor

sdelamo commented Mar 4, 2024

@wetted make sure logback version in core 4.4.x branch is aligned to logging. see: https://github.com/micronaut-projects/micronaut-core/blob/4.4.x/gradle/libs.versions.toml#L35

Copy link
Contributor Author

renovate bot commented Mar 4, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@wetted wetted requested review from timyates and sdelamo March 4, 2024 18:51
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wetted
Copy link
Contributor

wetted commented Mar 5, 2024

@wetted make sure logback version in core 4.4.x branch is aligned to logging. see: https://github.com/micronaut-projects/micronaut-core/blob/4.4.x/gradle/libs.versions.toml#L35

see micronaut-projects/micronaut-core#10504
It needs to be update again. I'll take care of it.

@sdelamo sdelamo merged commit 6ec1070 into master Mar 5, 2024
11 checks passed
@sdelamo sdelamo deleted the renovate/managed.logback branch March 5, 2024 11:44
@wetted
Copy link
Contributor

wetted commented Mar 7, 2024

@wetted make sure logback version in core 4.4.x branch is aligned to logging. see: https://github.com/micronaut-projects/micronaut-core/blob/4.4.x/gradle/libs.versions.toml#L35

see micronaut-projects/micronaut-core#10504 It needs to be update again. I'll take care of it.

Done. See micronaut-projects/micronaut-core#10583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants