aiorepl: Ignore second linefeed immediately after first #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandyscott
force-pushed
the
catch_double_newline
branch
2 times, most recently
from
50d2e6f to
2d01001
Compare
Pressing Enter or Return in a windows client will send two characters. both will received, as aiorepl reads characters one-by-one, both will be a linefeed after universal newline conversion. This change means the second linefeed is ignored
sandyscott
force-pushed
the
catch_double_newline
branch
from
2d01001 to
efb57a0
Compare
|
I really think that it needs to read from |
|
I was trying to keep this as minimal as possible, because I'm not sure what other effects that change might have, so I'll leave the PR open, and I have a slightly different one at #562 which implements the change to |
Ensure pc (previous character) is not immediately overwritten by the current character
|
As mentioned on the other PR - switching to binary mode introduces other issues, so I'll leave this open as a simple fix to resolve 1 windows newline being interpreted as 2 |
|
Thanks @sandyscott -- Merged in 81c1408 and d6eb5b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing Enter or Return in a windows client will send two characters. Both will received because aiorepl reads characters one-by-one, both will be a linefeed after universal newline conversion.
This change means the second linefeed is ignored