ports/unix: Disable the shared library of libffi #10383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10383 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 155 155
Lines 20528 20528
=======================================
Hits 20220 20220
Misses 308 308 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MicroPython doesn't need the shared library and disabling it in the configure could ease the build of a static version of MicroPython.
|
Thanks for the patch, this looks fine. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Jul 16, 2025
…5-28 9.2.x merge into main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was trying to build an static copy of MicroPython with zig as crosscompiler and I saw a problem building the shared library in the bundled copy of libffi. MicroPython doesn't need the shared library, so I disabled it in the configure.
The change was tested with gcc and clang and both pass the tests.