-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enhace the SVG usage in visual editor #1987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
reviewed
Feb 13, 2020
Composer/packages/extensions/visual-designer/src/components/lib/EdgeUtil.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/components/lib/EdgeUtil.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/components/lib/EdgeUtil.tsx
Outdated
Show resolved
Hide resolved
yeze322
changed the title
refactor: Implement a better EdgeUtil in visual editor
refactor: enhace the SVG usage in visual editor
Feb 13, 2020
yeze322
changed the title
refactor: enhace the SVG usage in visual editor
chore: enhace the SVG usage in visual editor
Feb 13, 2020
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
February 13, 2020 13:44
cwhitten
approved these changes
Feb 14, 2020
This was referenced Feb 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1497
resovles #1906
This PR improves the usage of SVG elements in VisualEditor, with the improvements, several pixel issues are fixed (#1906 ) and #1497 wil be closed.
Details
Covered 3 areas of changes:
<svg />
container per edge -> [after] multiple edges share one svg containerEdgeUtil
libEdgeComponent
which doesn't follows svg conventions1. semantic svg
<svg />
container (compared to previous solution, create a new svg container for every edge).<circle />
element<polyline />
instead of two lines2. fix pixel issues
[now]
[before]
[now]
[before]
3.
EdgeUtil lib
:As a result of 1&2, this PR contains a new lib for drawing edges and retires the old one
EdgeComponent
.Task Item
#1497
#1906
Screenshots