Add optional "deliveryMode" support for activity posting #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping it draft for now, we need to merge once ABS changes go live |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change introduces support for the deliveryMode property when posting activities through the Direct Line SDK.
Background
Azure Bot Service (ABS) is adding support for streaming responses via Direct Line. To enable this, clients must set deliveryMode: "stream" and use the activity protocol on POST /activities requests.
Currently, the DirectLineJS SDK does not expose deliveryMode as a configurable property, which prevents clients from opting into streaming.
Changes in this PR
Delivery mode doc - https://github.com/microsoft/Agents/blob/main/specs/activity/protocol-activity.md#delivery-mode