-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raft state refactoring #3218
Merged
wintersteiger
merged 8 commits into
microsoft:main
from
wintersteiger:cwinter_raft_state
Nov 23, 2021
Merged
Raft state refactoring #3218
wintersteiger
merged 8 commits into
microsoft:main
from
wintersteiger:cwinter_raft_state
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwinter_raft_state@37136 aka 20211123.20 vs main ewma over 20 builds from 36681 to 37115 Click to see table
|
wintersteiger
commented
Nov 17, 2021
wintersteiger
commented
Nov 17, 2021
achamayou
reviewed
Nov 17, 2021
wintersteiger
force-pushed
the
cwinter_raft_state
branch
from
November 18, 2021 10:54
d9dbbdc
to
597ec69
Compare
achamayou
approved these changes
Nov 22, 2021
jumaffre
reviewed
Nov 23, 2021
jumaffre
reviewed
Nov 23, 2021
wintersteiger
added a commit
to wintersteiger/CCF
that referenced
this pull request
Nov 24, 2021
* Raft state refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the raft state refactoring into separate leadership and membership states. There are two points I'm not happy with that I'll point out in comments.