Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raft state refactoring #3218

Merged
merged 8 commits into from
Nov 23, 2021
Merged

Conversation

wintersteiger
Copy link
Contributor

@wintersteiger wintersteiger commented Nov 17, 2021

This adds the raft state refactoring into separate leadership and membership states. There are two points I'm not happy with that I'll point out in comments.

@ccf-bot
Copy link
Collaborator

ccf-bot commented Nov 17, 2021

cwinter_raft_state@37136 aka 20211123.20 vs main ewma over 20 builds from 36681 to 37115

Click to see table
build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem Historical query (/s)^ CHAMP put (/s)^ CHAMP get (/s)^ RB put (/s)^ RB get (/s)^
36681 20211112.24 6814.16 9.13613e+07 23931.4 1.7961e+07 4522.95 1.56017e+07 2744.31 1.11453e+07 2426.6 1.0621e+07 1804.86 8.78598e+06 8357.96 1.45506e+06 3.58042e+07 nan nan
36691 20211115.2 6821.98 9.18856e+07 24285.1 1.7961e+07 4552.6 1.53396e+07 2774.26 1.37667e+07 2387.18 1.0621e+07 1822.87 8.78598e+06 8541.57 1.45495e+06 3.58669e+07 nan nan
36705 20211116.2 6654.62 9.24099e+07 24537.3 1.7961e+07 4491.25 1.56017e+07 2665.91 1.37667e+07 2425.92 1.0621e+07 1827.7 8.78598e+06 9540.78 1.45175e+06 3.58042e+07 nan nan
36751 20211117.9 6620.48 9.16235e+07 24006.1 1.90096e+07 4484.49 1.58639e+07 2670.36 1.4291e+07 2378.53 1.08831e+07 1821.28 8.78598e+06 8139.81 1.45083e+06 3.63759e+07 nan nan
36767 20211117.15 6618.15 9.16235e+07 24019.7 1.76989e+07 4525.01 1.58639e+07 2727.28 1.37667e+07 2438.02 1.0621e+07 1776.82 8.78598e+06 8838.48 1.44847e+06 3.58669e+07 nan nan
36792 20211118.2 6798.68 9.13613e+07 24277.4 1.82232e+07 4377.3 1.53396e+07 2722.15 1.19317e+07 2434.75 1.0621e+07 1784.24 9.04813e+06 8621.63 1.45837e+06 3.56794e+07 nan nan
36793 20211118.3 6738.99 9.10992e+07 24440.1 1.84853e+07 6101.31 1.6126e+07 2669.26 1.4291e+07 2407.59 1.27181e+07 2108.75 9.04813e+06 8791.74 1.44929e+06 3.63121e+07 nan nan
36809 20211118.8 6326.78 9.18856e+07 23525 1.76989e+07 6011.1 1.58639e+07 2742.9 1.21939e+07 2401.77 1.03588e+07 2033.48 9.04813e+06 9275.32 1.45795e+06 3.58042e+07 nan nan
36816 20211118.10 6589.49 9.13613e+07 24401.1 1.76989e+07 6289.66 1.6126e+07 2696.17 1.35046e+07 2418.3 1.0621e+07 2040.98 9.04813e+06 9310.17 1.45423e+06 3.58663e+07 nan nan
36844 20211118.19 6528.46 9.21478e+07 23667.4 1.7961e+07 6536.27 1.6126e+07 2702.65 1.0621e+07 2351.17 1.35046e+07 2044.63 9.04813e+06 9090.58 1.47741e+06 3.58663e+07 nan nan
36860 20211118.24 6760.33 9.18856e+07 24428 1.87475e+07 6474.2 1.6126e+07 2719.47 1.29803e+07 2410.65 1.32424e+07 2052.85 8.78598e+06 8675.68 1.45185e+06 3.58663e+07 nan nan
36870 20211119.2 6453.2 9.16235e+07 24352.1 1.7961e+07 6341.1 1.6126e+07 2743.24 1.08831e+07 2419.63 1.29803e+07 2087.28 9.04813e+06 8394.76 1.45423e+06 3.66369e+07 nan nan
36901 20211119.12 6258.02 9.16235e+07 24315.5 1.76989e+07 6091.26 1.58639e+07 2735.77 1.35046e+07 2401.36 1.21939e+07 2090.05 9.31027e+06 9019.86 1.45155e+06 3.58042e+07 nan nan
36917 20211119.17 6600.76 9.18856e+07 24240.4 1.7961e+07 6442.65 1.6126e+07 2707.54 1.40289e+07 2392.04 1.03588e+07 2088.05 9.04813e+06 9126.41 1.35745e+06 3.58042e+07 861115 9.25432e+06
36938 20211122.2 6601.12 9.16235e+07 24307.2 1.76989e+07 6098.95 1.58639e+07 2737.85 1.4291e+07 2391.3 1.32424e+07 2060.28 9.04813e+06 9025.4 1.37773e+06 3.58669e+07 855039 9.22518e+06
37004 20211122.22 6274.89 9.13613e+07 24096.5 1.7961e+07 6488.44 1.58639e+07 2645.8 1.03588e+07 2432.61 1.0621e+07 2062.16 9.04813e+06 8789.88 1.39594e+06 3.65714e+07 871294 9.21265e+06
37046 20211122.33 6682.39 9.29342e+07 24128 1.7961e+07 6560.71 1.56017e+07 2702.88 1.35046e+07 2439.69 1.03588e+07 2100.17 9.04813e+06 9461.14 1.36797e+06 3.58669e+07 861767 9.27952e+06
37059 20211123.2 6697.96 9.05749e+07 24232.6 1.82232e+07 6490.54 1.58639e+07 2728.74 1.35046e+07 2399.19 1.0621e+07 2039.34 1.19317e+07 9300.07 1.37164e+06 3.58042e+07 846874 9.57009e+06
37061 20211123.3 6681.54 9.05749e+07 24276.2 1.90096e+07 6456.22 1.56017e+07 2736.72 1.35046e+07 2361.27 1.37667e+07 2055.39 8.78598e+06 9040.21 1.37301e+06 3.56174e+07 863401 9.36867e+06
37115 20211123.15 6431.28 9.31964e+07 24069.3 1.76989e+07 6213.44 1.56017e+07 2737.5 1.11453e+07 2393.72 1.37667e+07 2105.04 8.78598e+06 9555.14 1.37081e+06 3.58663e+07 867717 9.30059e+06

images

@wintersteiger wintersteiger marked this pull request as ready for review November 17, 2021 18:10
@wintersteiger wintersteiger requested a review from a team as a code owner November 17, 2021 18:10
src/consensus/aft/raft.h Outdated Show resolved Hide resolved
src/consensus/aft/raft.h Outdated Show resolved Hide resolved
@wintersteiger wintersteiger merged commit 63e3a53 into microsoft:main Nov 23, 2021
@wintersteiger wintersteiger deleted the cwinter_raft_state branch November 23, 2021 15:54
wintersteiger added a commit to wintersteiger/CCF that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants