Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snmalloc to 0.6.0 #5186

Merged
merged 29 commits into from
Apr 20, 2023
Merged

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Apr 18, 2023

Following from #5165, this PR updates the snmalloc dependency to 0.6.0, in sync with what's provided via Open Enclave 0.19.0.

Since snmalloc no longers provides DLList, this PR also adds our own implementation in src/ds (along with unit tests), similar to the snmalloc implementation as discussed with @mjp41.

@ccf-bot
Copy link
Collaborator

ccf-bot commented Apr 18, 2023

update_snmalloc_0_6_0@68948 aka 20230419.69 vs main ewma over 20 builds from 68308 to 68940

Click to see table

main

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_virtual_cft^ ls_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
68308 20230413.11 0.80262 6260.11 8.21863e+07 17144 45708.2 15584.6 1.53396e+07 47762.8 16112.1 7.99955e+06 12778.2 13635.5 5562.34 1.45532e+07 5614.9 4.06739e+06 4205.29 3760.71 1505.21 7.73741e+06 3216.03 1319.4 7.21312e+06 43935.2 1238.69 6.95098e+06 829205 1.17134e+06 8.15413e+06 3.12638e+07
68330 20230413.20 0.793228 5688.34 8.32349e+07 17182.5 43827.4 15735.2 1.50774e+07 47259.4 16064.3 7.99955e+06 12248.9 12975.1 5523.08 1.48153e+07 5667.8 4.06739e+06 4240.85 3722.91 1503.74 7.73741e+06 3268.7 1316.57 7.47526e+06 44804 1233.42 6.95098e+06 836280 1.17953e+06 8.15257e+06 3.09132e+07
68374 20230413.33 0.798173 6220.09 8.27106e+07 17322.5 45589.1 15637.2 1.50774e+07 48886.4 16129.9 7.99955e+06 12688.4 13214.6 5508.92 1.48153e+07 5666.6 4.06739e+06 4435.93 3748.15 1504 7.73741e+06 3380.19 1312.41 7.21312e+06 44689.8 1235.93 6.95098e+06 829356 1.17599e+06 8.15011e+06 3.07028e+07
68383 20230413.36 0.805735 5606.69 8.29727e+07 17106.6 45881.3 15514.6 1.50774e+07 48292.4 16010.6 7.99955e+06 12276.4 13693.5 5473.76 1.45532e+07 5631.8 4.06739e+06 4458.04 3707.87 1487.36 7.73741e+06 3264.36 1307.43 7.99955e+06 42605.2 1210.28 6.95098e+06 833742 1.18003e+06 8.15283e+06 3.1468e+07
68402 20230414.4 0.80823 6289.92 8.21863e+07 17187.4 45867.2 15814 1.50774e+07 48529.8 16187.9 7.99955e+06 12874.3 13875.8 5560.83 1.48153e+07 5670.4 4.06739e+06 4263.83 3632.66 1506.42 7.73741e+06 3276.64 1327.36 7.21312e+06 45133.8 1240.87 6.95098e+06 830024 1.17124e+06 8.15504e+06 3.07397e+07
68410 20230414.8 0.798009 6310.83 8.21863e+07 17108.8 43772.1 15617.1 1.50774e+07 48479.7 16100.5 7.99955e+06 12769.6 13920 5541.71 1.45532e+07 5670.8 4.06739e+06 4439.71 3583.54 1507.23 7.73741e+06 3233.45 1312.64 7.47526e+06 45943.3 1232.23 6.95098e+06 839970 1.17944e+06 8.1555e+06 3.06536e+07
68516 20230414.34 0.799348 5628.62 8.24484e+07 17083.7 45825.4 15486.7 1.50774e+07 49725.5 15992.5 7.99955e+06 12332.7 12889.1 5561.54 1.48153e+07 5627.2 4.06739e+06 4435.14 3721.34 1489.43 7.73741e+06 3250.76 1296.85 7.47526e+06 45407.9 1225.68 6.95098e+06 837171 1.17883e+06 8.14787e+06 3.11767e+07
68527 20230417.2 0.767205 6277.54 8.21863e+07 17117.8 47850.5 15767.9 1.53396e+07 50189.5 16118.3 7.99955e+06 12399.3 13116.3 5559.33 1.48153e+07 5674.8 4.06739e+06 4460.79 3752.1 1507.57 7.73741e+06 3266.2 1318.39 7.73741e+06 46419.2 1231.74 6.95098e+06 823577 1.17993e+06 8.14936e+06 3.07752e+07
68574 20230417.16 0.804768 6238.13 8.21863e+07 17041.7 47949.4 15831.3 1.53396e+07 43806 16096.2 7.99955e+06 12199.3 13139.4 5559.88 1.45532e+07 5671.2 4.06739e+06 4263.07 3739.82 1506.13 7.73741e+06 3211.83 1319.16 7.47526e+06 45724.6 1233.86 6.95098e+06 840825 1.17591e+06 8.15595e+06 3.08778e+07
68677 20230417.36 0.828875 6313.33 8.21863e+07 17108.2 43752.7 15785.4 1.50774e+07 47151.4 16131.7 7.99955e+06 12430.1 12789.9 5530.47 1.45532e+07 5670 4.06739e+06 4266.35 3722.67 1510.24 7.73741e+06 3396.74 1315.69 7.21312e+06 47950.1 1235.08 6.95098e+06 838030 1.17422e+06 8.15449e+06 3.08132e+07
68693 20230418.2 0.757018 6288.59 8.21863e+07 17189.1 43600.4 15904.3 1.58639e+07 47023.2 16118.9 7.99955e+06 12471.4 13746.5 5573.78 1.45532e+07 5646.2 4.06739e+06 4251.16 3747.27 1509.97 7.73741e+06 3257.15 1313.79 7.47526e+06 46332.2 1235.86 6.95098e+06 835409 1.17998e+06 8.17186e+06 3.08648e+07
68696 20230418.4 0.788259 6272.37 8.24484e+07 17365.6 45704 15865.9 1.50774e+07 41977.5 16127.6 7.99955e+06 12456.2 13846 5542.62 1.45532e+07 5672 4.06739e+06 4447.66 3798.51 1508.48 7.73741e+06 3257.51 1313.48 7.21312e+06 46319.7 1237.83 6.95098e+06 834309 1.18203e+06 8.15134e+06 3.11848e+07
68740 20230419.1 0.785676 6297.62 8.19242e+07 17092.6 43642.6 15854.9 1.50774e+07 49067 16122.7 7.99955e+06 12540.6 13449.9 5522.26 1.45532e+07 5672.4 4.06739e+06 4381.43 3742.83 1509.32 7.73741e+06 3231.31 1324.27 7.21312e+06 46321.1 1242.27 6.95098e+06 830440 1.17572e+06 8.15154e+06 3.11298e+07
68749 20230419.6 0.794397 6230.77 8.1662e+07 17361.1 43696.8 15784.6 1.50774e+07 47499.9 16068.6 7.99955e+06 12881.3 12942 5507.37 1.45532e+07 5631.7 4.06739e+06 4283.48 3717.19 1492.51 7.73741e+06 3234.02 1317.45 7.21312e+06 44222.2 1238.57 6.95098e+06 835339 1.18013e+06 8.1554e+06 3.07942e+07
68773 20230419.13 0.790534 6266.11 8.27106e+07 17124.5 45576.1 15514.6 1.50774e+07 48522.3 16031.9 7.99955e+06 12754.6 13345.8 5465.13 1.4291e+07 5637.9 4.06739e+06 4435.66 3629.8 1491.14 7.73741e+06 3255.4 1309.25 7.21312e+06 43791.9 1226.62 6.95098e+06 833811 1.17996e+06 8.17209e+06 3.07415e+07
68786 20230419.18 0.801849 5568.73 8.27106e+07 17083.1 45807.1 15682.1 1.50774e+07 48440.9 16006.8 7.99955e+06 12895.1 13037.3 5515.83 1.45532e+07 5588.4 4.06739e+06 4456.78 3713.59 1483.76 7.73741e+06 3220.27 1304.39 7.21312e+06 45255.8 1233.77 6.95098e+06 832978 1.18074e+06 8.15478e+06 3.08578e+07
68828 20230419.29 0.792796 6240.27 8.19242e+07 17079.2 43846.6 15656.3 1.53396e+07 49557 15942.5 7.99955e+06 12897.5 12785.3 5507.67 1.45532e+07 5596.3 4.06739e+06 4446.35 3709.1 1483.81 7.73741e+06 3363.49 1295.01 7.47526e+06 46145.8 1226.82 6.95098e+06 831694 1.17711e+06 8.15504e+06 3.09595e+07
68887 20230419.51 0.784642 7321.36 8.59996e+07 17072.2 45636.7 20028.1 1.88908e+07 48788.8 20276.8 1.25993e+07 12721.6 13163.6 6341.76 1.67936e+07 6469.9 6.30784e+06 4439.14 3621.88 1707.71 1.05021e+07 3270.34 1508.41 1.05021e+07 47156.8 1403.61 1.05021e+07 830007 1.17519e+06 8.1529e+06 3.06996e+07
68891 20230419.53 0.780988 7359.59 8.59996e+07 17191.5 45739.2 20121.7 1.88908e+07 49836 20292.2 1.25993e+07 12641.5 12929.4 6334.92 1.67936e+07 6506.3 6.30784e+06 4406.39 3613.07 1710.21 1.05021e+07 3269.15 1504.71 1.05021e+07 51711.9 1400.58 1.05021e+07 787264 1.18205e+06 8.1554e+06 3.06936e+07
68940 20230419.67 0.789834 7270.63 8.59996e+07 17138.2 45671.4 20048.2 1.88908e+07 48678.7 20307.8 1.25993e+07 12882.5 12808.8 6374.79 1.67936e+07 6469.4 6.30784e+06 4270.59 3636.96 1729.13 1.05021e+07 3254.13 1506.5 1.05021e+07 51249.2 1403.07 1.05021e+07 832962 1.1784e+06 8.1553e+06 3.07332e+07

update_snmalloc_0_6_0

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem tpcc_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
68903 20230419.56 0.789648 7307.08 8.59996e+07 20052.4 1.88908e+07 20309.4 1.05021e+07 17312.5 6345.03 1.67936e+07 6423.1 6.30784e+06 45687.8 48206.2 12555.3 13070.4 1705.66 1.05021e+07 4441.2 3722.59 1489.99 1.05021e+07 3284.54 1391.49 1.05021e+07 51081.5 834810 1.1799e+06 8.15439e+06 3.08434e+07
68910 20230419.58 0.817872 7299.93 8.39025e+07 20134 1.88908e+07 20204.7 1.25993e+07 17299.5 6300.91 1.67936e+07 6468.6 6.30784e+06 45929.7 48613.1 12454.2 13178.2 1712.19 1.05021e+07 4451.35 3737.48 1505.22 1.05021e+07 3352.06 1399.01 1.05021e+07 48536.6 837608 1.17819e+06 8.14781e+06 3.05016e+07
68924 20230419.62 0.787864 7303.83 8.59996e+07 20075.4 1.88908e+07 20246.3 1.25993e+07 17367 6331.2 1.67936e+07 6471.6 6.30784e+06 45676.2 48670.6 12462.3 12187.3 1710.51 1.05021e+07 4414 3715.15 1492.78 1.05021e+07 3261.08 1400.1 1.05021e+07 51148.1 834353 1.16805e+06 8.17115e+06 3.13145e+07
68948 20230419.69 0.797696 7302.38 8.59996e+07 20080.8 1.88908e+07 20337.6 1.05021e+07 17702.1 6340.4 1.67936e+07 6514.7 6.30784e+06 45644.7 48935.4 12393.2 12808.7 1731.53 1.05021e+07 4468.92 3723.03 1501.42 1.05021e+07 3262.83 1418.78 1.05021e+07 51009.5 830345 1.17938e+06 8.13512e+06 3.11568e+07

images

@jumaffre jumaffre marked this pull request as ready for review April 19, 2023 15:26
@jumaffre jumaffre requested a review from a team as a code owner April 19, 2023 15:26
@jumaffre jumaffre merged commit 77c4a66 into microsoft:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants