Compute node count from a single pass over the JSON log file, eliminating the need for separate 'nodes' file. #5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
If this PR causes no regressions, I will force-push a commit to remove the generation of the CCF/tests/raft_scenarios_runner.py Lines 116 to 119 in a5495ca |
lemmy
force-pushed
the
mku-nodesfiles
branch
3 times, most recently
from
b990cc1
to
884b370
Compare
…ting the need for separate 'nodes' file.
achamayou
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted ("stolen") from @joshuazh-x trace specification. :-)