chore: Enable platform settings

.editorconfig

@@ -0,0 +1,9 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+indent_size = 4
+indent_style = space
+insert_final_newline = true
+trim_trailing_whitespace = true

ClearScript/DelegateFactory.tt

@@ -26,9 +26,9 @@ namespace Microsoft.ClearScript
             var allByValueExpr = (count == 0) ? "true" : "GetAllByValue(" + string.Join(", ", Enumerable.Range(1, count).Select(index => "typeof(T" + index + ")")) + ")";
             var methodParamList = string.Join(", ", Enumerable.Range(1, count).Select(index => "T" + index + " a" + index));
             var argList = string.Join(", ", Enumerable.Range(1, count).Select(index => "a" + index));
-            var varDeclList = string.Join("\r\n                    ", Enumerable.Range(1, count).Select(index => "var v" + index + " = GetArgValue(a" + index + ");"));
+            var varDeclList = string.Join("\n                    ", Enumerable.Range(1, count).Select(index => "var v" + index + " = GetArgValue(a" + index + ");"));
             var byRefArgList = string.Join(", ", Enumerable.Range(1, count).Select(index => "ref v" + index));
-            var varAssignList = string.Join("\r\n                        ", Enumerable.Range(1, count).Select(index => "SetArgValue(a" + index + ", v" + index + ");"));
+            var varAssignList = string.Join("\n                        ", Enumerable.Range(1, count).Select(index => "SetArgValue(a" + index + ", v" + index + ");"));
         #>
 
         [ExcludeFromCodeCoverage]
@@ -97,9 +97,9 @@ namespace Microsoft.ClearScript
             var allByValueExpr = (count == 0) ? "true" : "GetAllByValue(" + string.Join(", ", Enumerable.Range(1, count).Select(index => "typeof(T" + index + ")")) + ")";
             var methodParamList = string.Join(", ", Enumerable.Range(1, count).Select(index => "T" + index + " a" + index));
             var argList = string.Join(", ", Enumerable.Range(1, count).Select(index => "a" + index));
-            var varDeclList = string.Join("\r\n                ", Enumerable.Range(1, count).Select(index => "var v" + index + " = GetArgValue(a" + index + ");"));
+            var varDeclList = string.Join("\n                ", Enumerable.Range(1, count).Select(index => "var v" + index + " = GetArgValue(a" + index + ");"));
             var byRefArgList = string.Join(", ", Enumerable.Range(1, count).Select(index => "ref v" + index));
-            var varAssignList = string.Join("\r\n                    ", Enumerable.Range(1, count).Select(index => "SetArgValue(a" + index + ", v" + index + ");"));
+            var varAssignList = string.Join("\n                    ", Enumerable.Range(1, count).Select(index => "SetArgValue(a" + index + ", v" + index + ");"));
         #>
 
         [ExcludeFromCodeCoverage]

ClearScript/HostItem.InvokeMethod.cs

@@ -497,16 +497,26 @@ public bool IsUnblockedMethod(HostItem hostItem)
                 return IsSuccess && !method.IsBlockedFromScript(hostItem, hostItem.DefaultAccess);
             }
 
-            public object Invoke(HostItem hostItem)
-            {
-                if (!IsSuccess)
-                {
-                    throw exceptionFactory();
-                }
-
-                if (reflectionMethods.Contains(method, MemberComparer<MethodInfo>.Instance))
-                {
-                    hostItem.Engine.CheckReflection();
+            public object Invoke(HostItem hostItem)
+            {
+                if (!IsSuccess)
+                {
+                    throw exceptionFactory();
+                }
+
+                bool isReflectionMethod = false;
+                for (int i = 0; i < reflectionMethods.Length; i++)
+                {
+                    if (MemberComparer<MethodInfo>.Instance.Equals(reflectionMethods[i], method))
+                    {
+                        isReflectionMethod = true;
+                        break;
+                    }
+                }
+
+                if (isReflectionMethod)
+                {
+                    hostItem.Engine.CheckReflection();
                 }
 
                 return InvokeHelpers.InvokeMethod(hostItem, method, hostTarget.InvokeTarget, args, method.GetScriptMemberFlags(hostItem));

ClearScript/Properties/AssemblyInfo.V8.ICUData.cs

@@ -5,6 +5,14 @@
 
 
 
+
+
+
+
+
+
+
+
 using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
@@ -13,6 +21,7 @@
 [assembly: AssemblyProduct("ClearScript")]
 [assembly: AssemblyCopyright("(c) Microsoft Corporation")]
 [assembly: InternalsVisibleTo("ClearScript.V8")]
+[assembly: InternalsVisibleTo("Decentraland.ClearScript")]
 
 [assembly: ComVisible(false)]
 [assembly: AssemblyVersion("7.4.5")]

ClearScript/Properties/AssemblyInfo.V8.ICUData.tt

@@ -38,6 +38,7 @@ using System.Runtime.InteropServices;
 [assembly: AssemblyProduct("ClearScript")]
 [assembly: AssemblyCopyright("(c) Microsoft Corporation")]
 [assembly: InternalsVisibleTo("<#= "ClearScript.V8" + publicKeySpec #>")]
+[assembly: InternalsVisibleTo("Decentraland.ClearScript")]
 
 [assembly: ComVisible(false)]
 [assembly: AssemblyVersion("<#= version.ToString(3) #>")]

ClearScript/Util/EnumUtils.cs

@@ -0,0 +1,25 @@
+using System;
+
+internal static class EnumUtils
+{
+    public static unsafe bool HasFlagNonAlloc<T>(this T x, T y) where T : unmanaged, Enum
+    {
+        switch (sizeof(T))
+        {
+            case sizeof(byte):
+                return (*(byte*) &x & *(byte*) &y) != 0;
+
+            case sizeof(short):
+                return (*(short*) &x & *(short*) &y) != 0;
+
+            case sizeof(int):
+                return (*(int*) &x & *(int*) &y) != 0;
+
+            case sizeof(long):
+                return (*(long*) &x & *(long*) &y) != 0L;
+
+            default:
+                return false;
+        }
+    }
+}

ClearScript/Util/ObjectHelpers.Common.cs

@@ -11,6 +11,9 @@ internal static partial class ObjectHelpers
     {
         private static bool GetPrimaryInteropAssembly(Guid libid, int major, int minor, out string name, out string codeBase)
         {
+#if UNITY_5_3_OR_NEWER // There is no just "is Unity" symbol.
+            throw new NotSupportedException("What the hell are you doing with COM in a Unity game??");
+#else
             name = null;
             codeBase = null;
 
@@ -37,7 +40,8 @@ private static bool GetPrimaryInteropAssembly(Guid libid, int major, int minor,
                 }
             }
 
-            return name != null;
+            return name != null;
+#endif
         }
     }
 }

ClearScript/V8/SplitProxy/IV8HostObject.cs

@@ -0,0 +1,116 @@
+using System;
+
+namespace Microsoft.ClearScript.V8.SplitProxy
+{
+    /// <summary>
+    /// Implement this interface to talk to ClearScript's native wrapper around V8 directly.
+    /// </summary>
+    public interface IV8HostObject
+    {
+        /// <summary>
+        /// Implement this to support getting the values of named properties.
+        /// </summary>
+        /// <param name="name">The name of the property JavaScript wants the value of.</param>
+        /// <param name="value">Write the value of the property here.</param>
+        /// <param name="isConst">If you set this to to true, V8 will cache the value not ask for it
+        /// again.</param>
+        void GetNamedProperty(StdString name, V8Value value, out bool isConst) =>
+            throw new NotImplementedException($"Named property {name.ToString()} is not implemented");
+
+        /// <summary>
+        /// Implement this to support setting the values of named properties.
+        /// </summary>
+        /// <param name="name">The name of the property JavaScript wants to set.</param>
+        /// <param name="value">The value JavaScript wants to set the property to.</param>
+        void SetNamedProperty(StdString name, V8Value.Decoded value) =>
+            throw new NotImplementedException($"Named property {name.ToString()} is not implemented");
+
+        /// <summary>
+        /// Implement this to support deleting named properties.
+        /// </summary>
+        /// <param name="name">The name of the property JavaScript wants to delete.</param>
+        /// <returns>TODO</returns>
+        bool DeleteNamedProperty(StdString name) =>
+            throw new NotImplementedException($"Named property {name.ToString()} is not implemented");
+
+        /// <summary>
+        /// Implement this to support getting the values of indexed properties.
+        /// </summary>
+        /// <param name="index">The index of the property JavaScript wants the value of.</param>
+        /// <param name="value">Write the value of the property here.</param>
+        void GetIndexedProperty(int index, V8Value value) =>
+            throw new NotImplementedException($"Indexed property {index} is not implemented");
+
+        /// <summary>
+        /// Implement this to support setting the values of indexed properties.
+        /// </summary>
+        /// <param name="index">The index of the property JavaScript wants to set.</param>
+        /// <param name="value">The value JavaScript wants to set the property to.</param>
+        void SetIndexedProperty(int index, V8Value.Decoded value) =>
+            throw new NotImplementedException($"Indexed property {index} is not implemented");
+
+        /// <summary>
+        /// Implement this to support deleting indexed properties.
+        /// </summary>
+        /// <param name="index">The index of the property JavaScript wants to delete.</param>
+        /// <returns>TODO</returns>
+        bool DeleteIndexedProperty(int index) =>
+            throw new NotImplementedException($"Indexed property {index} is not implemented");
+
+        /// <summary>
+        /// Implement this to support being enumerated.
+        /// </summary>
+        /// <param name="result">Write the enumerator here.</param>
+        /// <remarks>
+        /// The enumerator class should implement <see cref="IV8HostObject"/> and implement MoveNext(),
+        /// ScriptableDispose(), and CurrentValue.
+        /// </remarks>
+        void GetEnumerator(V8Value result) =>
+            throw new NotImplementedException("Enumerator is not implemented");
+
+        /// <summary>
+        /// Implement this to support being async enumerated.
+        /// </summary>
+        /// <param name="result">Write the async enumerator here.</param>
+        void GetAsyncEnumerator(V8Value result) =>
+            throw new NotImplementedException("Async enumerator is not implemented");
+
+        /// <summary>
+        /// Implement this to support listing of all your named proeprties.
+        /// </summary>
+        /// <param name="names">Write the names of your properties here.</param>
+        void GetNamedPropertyNames(StdStringArray names) =>
+            throw new NotImplementedException("Listing named properties is not implemented");
+
+        /// <summary>
+        /// Implement this to support listing all your indexed properties.
+        /// </summary>
+        /// <param name="indices">Write the indices of your properties here.</param>
+        void GetIndexedPropertyIndices(StdInt32Array indices) =>
+            throw new NotImplementedException("Listing indexed properties is not implemented");
+
+        /// <summary>
+        /// I don't know when ClearScript calls this.
+        /// </summary>
+        /// <param name="name">The name of the method JavaScript wants to invoke.</param>
+        /// <param name="args">The arguments JavaScript is passing to the method.</param>
+        /// <param name="result">Write the return value, if not <see cref="void"/>, of the method here.
+        /// </param>
+        void InvokeMethod(StdString name, ReadOnlySpan<V8Value.Decoded> args, V8Value result)
+        {
+            GetNamedProperty(name, result, out _);
+            object method = result.Decode().GetHostObject();
+            result.SetNonexistent();
+            ((InvokeHostObject)method)(args, result);
+        }
+    }
+
+    /// <summary>
+    /// Return a delegate of this type from a property to tell JavaScript that it is a callable
+    /// function.
+    /// </summary>
+    /// <param name="args">The arguments JavaScript will pass to your method when invoking it.</param>
+    /// <param name="result">Write the return value, if not <see cref="void"/>, of the method here.
+    /// </param>
+    public delegate void InvokeHostObject(ReadOnlySpan<V8Value.Decoded> args, V8Value result);
+}

ClearScript/V8/SplitProxy/IV8SplitProxyNative.cs

@@ -19,6 +19,7 @@ internal interface IV8SplitProxyNative
 
         StdString.Ptr StdString_New(string value);
         string StdString_GetValue(StdString.Ptr pString);
+        void StdString_GetValue(StdString.Ptr pString, out IntPtr value, out int length);
         void StdString_SetValue(StdString.Ptr pString, string value);
         void StdString_Delete(StdString.Ptr pString);
 
@@ -171,6 +172,7 @@ internal interface IV8SplitProxyNative
         void V8Context_AwaitDebuggerAndPause(V8Context.Handle hContext);
         void V8Context_CancelAwaitDebugger(V8Context.Handle hContext);
         object V8Context_ExecuteCode(V8Context.Handle hContext, string resourceName, string sourceMapUrl, ulong uniqueId, DocumentKind documentKind, IntPtr pDocumentInfo, string code, bool evaluate);
+        void V8Context_ExecuteCode(V8Context.Handle hContext, StdString.Ptr pResourceName, StdString.Ptr pSourceMapUrl, ulong uniquId, DocumentKind documentKind, IntPtr pDocumentInfo, StdString.Ptr pCode, bool evaluate, V8Value.Ptr pResult);
         V8Script.Handle V8Context_Compile(V8Context.Handle hContext, string resourceName, string sourceMapUrl, ulong uniqueId, DocumentKind documentKind, IntPtr pDocumentInfo, string code);
         V8Script.Handle V8Context_CompileProducingCache(V8Context.Handle hContext, string resourceName, string sourceMapUrl, ulong uniqueId, DocumentKind documentKind, IntPtr pDocumentInfo, string code, V8CacheKind cacheKind, out byte[] cacheBytes);
         V8Script.Handle V8Context_CompileConsumingCache(V8Context.Handle hContext, string resourceName, string sourceMapUrl, ulong uniqueId, DocumentKind documentKind, IntPtr pDocumentInfo, string code, V8CacheKind cacheKind, byte[] cacheBytes, out bool cacheAccepted);
@@ -199,17 +201,21 @@ internal interface IV8SplitProxyNative
         #region V8 object methods
 
         object V8Object_GetNamedProperty(V8Object.Handle hObject, string name);
+        void V8Object_GetNamedProperty(V8Object.Handle hObject, StdString.Ptr pName, V8Value.Ptr pValue);
         bool V8Object_TryGetNamedProperty(V8Object.Handle hObject, string name, out object value);
         void V8Object_SetNamedProperty(V8Object.Handle hObject, string name, object value);
         bool V8Object_DeleteNamedProperty(V8Object.Handle hObject, string name);
         string[] V8Object_GetPropertyNames(V8Object.Handle hObject, bool includeIndices);
         object V8Object_GetIndexedProperty(V8Object.Handle hObject, int index);
+        void V8Object_GetIndexedProperty(V8Object.Handle hObject, int index, V8Value.Ptr pValue);
         void V8Object_SetIndexedProperty(V8Object.Handle hObject, int index, object value);
         bool V8Object_DeleteIndexedProperty(V8Object.Handle hObject, int index);
         int[] V8Object_GetPropertyIndices(V8Object.Handle hObject);
         object V8Object_Invoke(V8Object.Handle hObject, bool asConstructor, object[] args);
+        void V8Object_Invoke(V8Object.Handle hObject, bool asConstructor, StdV8ValueArray.Ptr pArgs, V8Value.Ptr pResult);
         object V8Object_InvokeMethod(V8Object.Handle hObject, string name, object[] args);
         void V8Object_GetArrayBufferOrViewInfo(V8Object.Handle hObject, out IV8Object arrayBuffer, out ulong offset, out ulong size, out ulong length);
+        void V8Object_GetArrayBufferOrViewInfo(V8Object.Handle hObject, V8Value.Ptr pArrayBuffer, out ulong offset, out ulong size, out ulong length);
         void V8Object_InvokeWithArrayBufferOrViewData(V8Object.Handle hObject, IntPtr pAction);
 
         #endregion

ClearScript/V8/SplitProxy/NativeCallbackImpl.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
 using System;
@@ -21,7 +21,10 @@ public NativeCallbackImpl(NativeCallback.Handle hCallback)
 
         public void Invoke()
         {
-            V8SplitProxyNative.InvokeNoThrow(instance => instance.NativeCallback_Invoke(Handle));
+            using (V8SplitProxyNative.InvokeNoThrow(out var instance))
+            {
+                instance.NativeCallback_Invoke(Handle);
+            }
         }
 
         #endregion

ClearScript/V8/SplitProxy/Uint8Array.cs

@@ -0,0 +1,56 @@
+using System;
+using System.Runtime.InteropServices;
+
+namespace Microsoft.ClearScript.V8.SplitProxy
+{
+    /// <summary>
+    /// Wraps a Uint8Array, an array of <see cref="byte"/>.
+    /// </summary>
+    public readonly ref struct Uint8Array
+    {
+        private readonly V8Object.Handle ptr;
+
+        internal Uint8Array(V8Object.Handle pArray)
+        {
+            ptr = pArray;
+            using var arrayBuffer = V8Value.New();
+
+            V8SplitProxyNative.Instance.V8Object_GetArrayBufferOrViewInfo(pArray, arrayBuffer.ptr,
+                out _, out _, out ulong length);
+
+            Length = (int)length;
+        }
+
+        /// <summary>
+        /// Copy the contents of the wrapped Uint8Array to a managed <see cref="byte"/> array.
+        /// </summary>
+        /// <param name="array">The destination array. It must be large enough to contain the entire
+        /// contents of the wrapped Uint8Array.</param>
+        public void CopyTo(byte[] array)
+        {
+            int length = Length;
+
+            if (length > array.Length)
+                throw new IndexOutOfRangeException(
+                    $"Tried to copy {length} items to a {array.Length} item array");
+
+            // TODO: Don't allocate a lambda every time.
+            IntPtr pAction = V8ProxyHelpers.AddRefHostObject(new Action<IntPtr>(data =>
+                Marshal.Copy(data, array, 0, length)));
+
+            try
+            {
+                V8SplitProxyNative.Instance.V8Object_InvokeWithArrayBufferOrViewData(ptr, pAction);
+            }
+            finally
+            {
+                V8ProxyHelpers.ReleaseHostObject(pAction);
+            }
+        }
+
+        /// <summary>
+        /// The length of the wrapped Uint8Array.
+        /// </summary>
+        public int Length { get; }
+    }
+}