Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DirectXMath.h to address GCC #pragma warning warnings #134

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Update DirectXMath.h to address GCC #pragma warning warnings #134

merged 1 commit into from
Nov 29, 2021

Conversation

sbd1138
Copy link
Contributor

@sbd1138 sbd1138 commented Oct 16, 2021

Wrap #pragma warnings to avoid GCC compilation warnings

@sbd1138
Update DirectXMath.h
b2e30da 
Wrap #pragma warnings to avoid GCC compilation warnings
@ghost
Copy link

ghost commented Oct 16, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@walbourn walbourn linked an issue Oct 17, 2021 that may be closed by this pull request
GCC #pragma warning warnings #133
Closed
@walbourn walbourn self-assigned this Oct 17, 2021
@walbourn walbourn added the complier Issue related to compiler codegen label Nov 29, 2021
@walbourn walbourn merged commit f4e6ac0 into microsoft:master Nov 29, 2021
walbourn added a commit that referenced this pull request Nov 29, 2021
@walbourn
Wrap #pragma warnings to avoid GCC compilation warnings (#134, #135)
3734bc9
@walbourn
Copy link
Member

walbourn commented Nov 29, 2021 •
edited
Loading

Your test covered #include <DirectXMath.h>, but you missed #include <DirectXPackedVector.h> and #include <DirectXCollision.h>.

I updated those in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walbourn walbourn walbourn approved these changes

Assignees

@walbourn walbourn

Labels
complier Issue related to compiler codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCC #pragma warning warnings
2 participants
@sbd1138 @walbourn