Adjust folder structure #34
Conversation
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/telemetry-support
branch
3 times, most recently
from
6b802cf to
c397db9
Compare
zhiyuanliang-ms
requested review from
Eskibear,
linglingye001 and
rossgrambo
scripts/build-and-pack.sh
Outdated
| SDK_DIR="$PROJECT_BASE_DIR/sdk" | ||
|
|
||
| # Loop through each package in the sdk folder. | ||
| for PACKAGE_DIR in "$SDK_DIR"/*; do |
There was a problem hiding this comment.
this script is all-in-one. Suppose you will have multiple packages later, do you want to create RC bits and release for all of them everytime? If so, that's fine. If you will release one of these packages alone, I would suggest you accept package_dir as a parameter of this script.
There was a problem hiding this comment.
It indeed takes me a while to find where telemetry support is added, mixed with the file renaming. A general suggestion is to make the file moving into a separate PR and focus on telemetry part in this PR. That would make it easier to review.
There was a problem hiding this comment.
...and I have to double check whether there's additional changes in each renamed file.
There was a problem hiding this comment.
Revert the change. Only keep the change of folder structure change in this PR.
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/telemetry-support
branch
from
53085fc to
75bb990
Compare
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/telemetry-support
branch
from
75bb990 to
e953caf
Compare
Why this PR?
The repo folder structure has been changed to accommodate more packages in the future.