Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] updated status badges #1512

Merged
merged 1 commit into from
Jul 13, 2018
Merged

[docs] updated status badges #1512

merged 1 commit into from
Jul 13, 2018

Conversation

StrikerRUS
Copy link
Collaborator

Fixed VSTS status badge and added link for the latest build at master branch.

Also reordered badges because of design reasons: VSTS and Appveyor badges have icons and same color pallet and now are shown close to each other.
Result: https://github.com/Microsoft/LightGBM/blob/badges/README.md

Not sure about definitionId=7 in VSTS URL. I just took this from here:
image

@StrikerRUS StrikerRUS requested a review from guolinke July 12, 2018 19:13
@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Jul 12, 2018

And what is the decision about Travis and Appveyor after this PR will be merged? Will they be removed or left along with VSTS?

I think we can keep Travis, since it is very fast.

@guolinke BTW, I think we can not remove Appveyor checks at all, because they are very stable. instead we can find the number of jobs which will finish approximately in the same time as VSTS or Travis ones. For instance, it could be MinGW builds.

UPD:
And is it possible to remove necessary merging master branch in PRs?

@guolinke
Copy link
Collaborator

@StrikerRUS I think vsts also can build mingw version. But I don't have time to enable it...

@guolinke guolinke merged commit c647b66 into master Jul 13, 2018
@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Jul 13, 2018

@guolinke Yeah, but you said that we are limited by 10 parallel jobs at VSTS, so I think we can benefit from balancing the builds between Appveyor and VSTS. At least, Appveyor can be "11th" parallel build.

I'll do some experiments with the building time and create a PR with new tests allocation between CI services (after all problems with VSTS will be solved).

@StrikerRUS StrikerRUS deleted the badges branch July 13, 2018 09:41
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants