Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Bug fix for first_metric_only on earlystopping. #2209

Merged
merged 72 commits into from
Sep 15, 2019
Merged

[python] Bug fix for first_metric_only on earlystopping. #2209

merged 72 commits into from
Sep 15, 2019

Commits on Jun 1, 2019

  1. Bug fix for first_metric_only if the first metric is train metric.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    0c9c77c View commit details
    Browse the repository at this point in the history

  2. Update bug fix for feval issue.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    130fe38 View commit details
    Browse the repository at this point in the history

  3. Disable feval for first_metric_only.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    7ab1a59 View commit details
    Browse the repository at this point in the history

  4. Additional test items.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    ba8a5aa View commit details
    Browse the repository at this point in the history

  5. Fix wrong assertEqual settings & formating.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    25850fa View commit details
    Browse the repository at this point in the history

  6. Change dataset of test.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    fddf8da View commit details
    Browse the repository at this point in the history

  7. Fix random seed for test.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    6b71ebc View commit details
    Browse the repository at this point in the history

  8. Modiry assumed test result due to different sklearn verion between CI… 

    … and local.
    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    979f4df View commit details
    Browse the repository at this point in the history

  9. Remove f-string

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    5e68ae9 View commit details
    Browse the repository at this point in the history

  10. Applying variable assumed test result for test.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    0f196e2 View commit details
    Browse the repository at this point in the history

  11. Fix flake8 error.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    c0d61fa View commit details
    Browse the repository at this point in the history

  12. Modifying in accordance with review comments.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    0e91956 View commit details
    Browse the repository at this point in the history

  13. Modifying for pylint.

    @matsuken92
    matsuken92 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    6f30b81 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2019

  1. simplified tests

    @StrikerRUS
    StrikerRUS committed Jun 2, 2019
    Configuration menu
    Copy the full SHA
    3770cc1 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. Deleting error criteria if eval_metric is None.

    @matsuken92
    matsuken92 committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    c4e0af5 View commit details
    Browse the repository at this point in the history

  2. Delete test items of classification.

    @matsuken92
    matsuken92 committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    2f4e2b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. Simplifying if condition.

    @matsuken92
    matsuken92 committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    9387197 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Applying first_metric_only for sklearn wrapper.

    @matsuken92
    matsuken92 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    5aeb2bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix/first_metric_only_train_metric

    @matsuken92
    matsuken92 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    79ba017 View commit details
    Browse the repository at this point in the history

  3. Modifying test_sklearn for comforming to python 2.x

    @matsuken92
    matsuken92 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    c40408c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bugfix/first_metric_only_train_metric' of https://githu… 

    …b.com/matsuken92/LightGBM into bugfix/first_metric_only_train_metric
    @matsuken92
    matsuken92 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    6a70b0c View commit details
    Browse the repository at this point in the history

  5. Fix flake8 error.

    @matsuken92
    matsuken92 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    fe7d586 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. Additional fix for sklearn and add tests.

    @matsuken92
    matsuken92 committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    71c1bc2 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. Bug fix and add test cases.

    @matsuken92
    matsuken92 committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    3e956ea View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. some refactor

    @StrikerRUS
    StrikerRUS committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    0338bc7 View commit details
    Browse the repository at this point in the history

  2. fixed lint

    @StrikerRUS
    StrikerRUS committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    75d7c57 View commit details
    Browse the repository at this point in the history

  3. fixed lint

    @StrikerRUS
    StrikerRUS committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    4645126 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2019

  1. Fix duplicated metrics scores to pass the test.

    @matsuken92
    matsuken92 committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    60233bb View commit details
    Browse the repository at this point in the history

  2. Fix the case first_metric_only not in params.

    @matsuken92
    matsuken92 committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    f3f1e83 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Converting metrics aliases.

    @matsuken92
    matsuken92 committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    e054f97 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Add comment.

    @matsuken92
    matsuken92 committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    4e62ef7 View commit details
    Browse the repository at this point in the history

  2. Modify comment for pylint.

    @matsuken92
    matsuken92 committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    3b154b6 View commit details
    Browse the repository at this point in the history

  3. Modify comment for pydocstyle.

    @matsuken92
    matsuken92 committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    6dc7e85 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2019

  1. Using split test set for two eval_set.

    @matsuken92
    matsuken92 committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    1dc5397 View commit details
    Browse the repository at this point in the history

  2. added test case for metric aliases and length checks

    @StrikerRUS
    StrikerRUS committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    ebc97b3 View commit details
    Browse the repository at this point in the history

  3. minor style fixes

    @StrikerRUS
    StrikerRUS committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    f7f0dfe View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. fixed rmse name and alias position

    @StrikerRUS
    StrikerRUS committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    4221b8a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Fix the case metric=[]

    @matsuken92
    matsuken92 committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    5470265 View commit details
    Browse the repository at this point in the history

  2. Fix using env.model._train_data_name

    @matsuken92
    matsuken92 committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    e292b39 View commit details
    Browse the repository at this point in the history

  3. Fix wrong test condition.

    @matsuken92
    matsuken92 committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    ffa95b8 View commit details
    Browse the repository at this point in the history

  4. Move initial process to _init() func.

    @matsuken92
    matsuken92 committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    3403f7b View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2019

  1. Merge remote-tracking branch 'upstream/master' into bugfix/first_metr… 

    …ic_only_train_metric
    @matsuken92
    matsuken92 committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    43ea2df View commit details
    Browse the repository at this point in the history

  2. Modify test setting for test_sklearn & training data matching on call… 

    …back.py

* test_sklearn.py
-> A test case for training is wrong, so fixed.

* callback.py
-> A condition of if statement for detecting test dataset is wrong, so fixed.
    @matsuken92
    matsuken92 committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    b509afa View commit details
    Browse the repository at this point in the history

  3. Support composite name metrics.

    @matsuken92
    matsuken92 committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    c4e4b33 View commit details
    Browse the repository at this point in the history

  4. Remove metric check process & reduce redundant test cases. 

    For microsoft#2273 fixed not only the order of metrics in cpp, removing metric check process at callback.py
    @matsuken92
    matsuken92 committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    2f1578c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Revised according to the matters pointed out on a review.

    @matsuken92
    matsuken92 committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    45fc5eb View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. increased code readability

    @StrikerRUS
    StrikerRUS committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    f270258 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2019

  1. Fix the issue of order of validation set.

    @matsuken92
    matsuken92 committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    df03f4c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bugfix/first_metric_only_train_metric' of https://githu… 

    …b.com/matsuken92/LightGBM into bugfix/first_metric_only_train_metric
    @matsuken92
    matsuken92 committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    37770b0 View commit details
    Browse the repository at this point in the history

  3. Changing to OrderdDict from default dict for score result.

    @matsuken92
    matsuken92 committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    0a73a67 View commit details
    Browse the repository at this point in the history

  4. added missed check in cv function for first_metric_only and feval co-… 

    …occurrence
    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    6209c4a View commit details
    Browse the repository at this point in the history

  5. keep order only for metrics but not for datasets in best_score

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    ea0312a View commit details
    Browse the repository at this point in the history

  6. move OrderedDict initialization to init phase

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    c881171 View commit details
    Browse the repository at this point in the history

  7. fixed minor printing issues

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    386fe1c View commit details
    Browse the repository at this point in the history

  8. move first metric detection to init phase and split can be performed … 

    …without checks
    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    8fe0469 View commit details
    Browse the repository at this point in the history

  9. split only once during callback

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    13737ac View commit details
    Browse the repository at this point in the history

  10. removed excess code

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    5128b34 View commit details
    Browse the repository at this point in the history

  11. fixed typo in variable name and squashed ifs

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    ca4fd0c View commit details
    Browse the repository at this point in the history

  12. use setdefault

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    cb9e327 View commit details
    Browse the repository at this point in the history

  13. hotfix

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    97004e0 View commit details
    Browse the repository at this point in the history

  14. fixed failing test

    @StrikerRUS
    StrikerRUS committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    19319c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2019

  1. refined tests

    @StrikerRUS
    StrikerRUS committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    58a800c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. refined sklearn test

    @StrikerRUS
    StrikerRUS committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    f5a2b74 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Making "feval" effective on early stopping.

    @matsuken92
    matsuken92 committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    b7a03e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix/first_metric_only_train_metric

    @matsuken92
    matsuken92 committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    47b7a23 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. fixed conflicts

    @StrikerRUS
    StrikerRUS committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    5c99e7e View commit details
    Browse the repository at this point in the history

  2. allow feval and first_metric_only for cv

    @StrikerRUS
    StrikerRUS committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    15a5fc2 View commit details
    Browse the repository at this point in the history

  3. removed unused code

    @StrikerRUS
    StrikerRUS committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    d20b338 View commit details
    Browse the repository at this point in the history

  4. added tests for feval

    @StrikerRUS
    StrikerRUS committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    c3fbf6b View commit details
    Browse the repository at this point in the history

  5. fixed printing

    @StrikerRUS
    StrikerRUS committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    cbaadbe View commit details
    Browse the repository at this point in the history

  6. add note about whitespaces in feval name

    @StrikerRUS
    StrikerRUS committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    a2d6449 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Modifying final iteration process in case valid set is training data.

    @matsuken92
    matsuken92 committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    88050da View commit details
    Browse the repository at this point in the history