Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][SWIG] update SWIG version and use separate CI job to produce SWIG artifacts #3727

Merged
merged 13 commits into from
Jan 19, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Closed #3716.

@imatiach-msft Hi! Could you please help to review this PR?

I'm attaching links to Windows and macOS artifacts to this message (GitHub doesn't allow attaching archives directly due to filetype restrictions), so that you are able to test them. I'm not attaching Linux artifact here, because updating SWIG for Linux requires more actions in https://github.com/guolinke/lightgbm-ci-docker. But it should be quite straightforward if you find artifacts for other OSes generally OK with new SWIG version. But feel free to ask for Linux artifact as well if you need to test it.

https://github.com/microsoft/LightGBM/releases/download/v2.0.12/lightgbmlib_macos.jar
https://github.com/microsoft/LightGBM/releases/download/v2.0.12/lightgbmlib_win.jar

@StrikerRUS
Copy link
Collaborator Author

gently ping @imatiach-msft

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for updating SWIG version! Just checking, will I still be able to get SWIG artifacts on every commit build on master after this PR?

@imatiach-msft
Copy link
Contributor

imatiach-msft commented Jan 19, 2021

@StrikerRUS I just took a look at both the jar files for windows and mac, they look great to me, thank you!

@StrikerRUS
Copy link
Collaborator Author

@imatiach-msft Thank you very much for trying new artifacts! Glad they are working!

Just checking, will I still be able to get SWIG artifacts on every commit build on master after this PR?

Yeah, absolutely! Nothing is changing related to artifacts side. I only moved SWIG part to a separate job with the aim to make code and process clearer. Same environment, same checks for linked libraries versions, same artifacts, same names, etc.

The only thing I want to make you aware is that Docker changes with SWIG updates can take some time. So it is possible that some commits in the nearest future right after merging this PR will produce inconsistent artifacts. I mean, macOS and Windows will be built with SWIG4, while Linux artifacts will still be using SWIG3. I hope it will not take more than 1-2 days. And I'll ping you after sync will be finished.

@StrikerRUS StrikerRUS merged commit a292766 into master Jan 19, 2021
@StrikerRUS StrikerRUS deleted the swig branch January 19, 2021 15:05
@StrikerRUS
Copy link
Collaborator Author

@imatiach-msft Well, Docker has been successfully built!
It means that all next commits to the master branch after 4007b34 will be producing artifacts generated with SWIG version 4 for all OSes.

image

Feel free to ping me in case of any issues. We can rollback SWIG version bumping any time.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use latest SWIG version to build jar artifacts
3 participants