[tests][dask] Use workers hostname in tests (fixes #4594) #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
approved these changes
Sep 6, 2021
StrikerRUS
approved these changes
Sep 7, 2021
jameslamb
changed the title
|
Closing-reopening because simple rerun doesn't help with QEMU timeout error. |
One more time. |
|
After multiple close-and-reopens with the QEMU builds still timing out, I think we need to merge #4600 before this one. |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4594.
Since the dask tests run on a
LocalClusterwe used127.0.0.1as the host for the workers, however something seems to have changed and on my machine (ubuntu) now the scheduler gets127.0.0.1and the workers get192.168.100.4and in the QEMU build they're getting172.17.0.2. This PR extracts the hostname from the worker addresses to run the tests that require using the workers' addresses.