-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v4.4.0 #6439
release v4.4.0 #6439
Conversation
@shiyu1994 @guolinke @jmoralez @borchero @btrotta to help with the release, could you please do the following?
Thank you! |
Plan sounds great to me, thanks a lot for taking care of the release @jameslamb! I think that |
Thank you @jameslamb for the releasing. I don't think we have anything urgent to be included in v4.4.0 for now. |
Please add verbose fix in this new version... |
I've added #6454 to the list of issues to resolve for this release. I'll prioritize that this week. Added that because |
Alright I think we are close! I'm sorry for the rush, but could we please try to finish the release in the next 3 days, so we could hopefully put up a release of the Python package prior to I think we can get it done. I can do all of the release tasks to get this PR ready, but could use some help on reviews of the following:
@guolinke @shiyu1994 @borchero @jmoralez if you have time in the next few days, could you help with reviews on those? While that's going on, I'll continue trying to help @jmoralez unblock R CI in #6442, and I can review that PR and #6377. |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
Alright I think this is ready! @guolinke @shiyu1994 @jmoralez @borchero could you please take a look when you have time? Once at least 2 people have approved (and at least one of @guolinke and @shiyu1994 ), I'll merge this and proceed with the release (pushing tags, publishing release notes, etc.). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for getting this over the line @jameslamb! Sorry for being inactive the last few days... 😬
Don't worry about it @borchero ! We're mostly all volunteers here, with availability that varies week-to-week. Appreciate all your help on the other contributions that led up to this release being almost-ready today 😁 |
Thanks everyone! Whenever CI passes here, I'll merge this and continue with the release. |
Ran the following to create the git checkout master
git pull upstream master
git fetch upstream --tags
git tag -d stable
git push upstream :refs/tags/stable
git tag stable
git tag v4.4.0
git push upstream stable v4.4.0 (NOTE: I alias this repo to https://github.com/microsoft/LightGBM/tags That triggered an Azure DevOps build which should create the release automatically: https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=16384&view=results This takes around 90 minutes (because of the QEMU CI job). I'll check back in a few hours and continue the release then. |
These are done.
And v4.4.0 in the selector: |
The release is now published here on GitHub: |
Uploaded to test PyPI and tested installing from it (including running lightgbm's tests) on my M2 Mac. That worked! So published to real PyPI.
|
put up dev version PR: #6485 |
|
The R package has passed all checks at https://cran.r-project.org/web/checks/check_results_lightgbm.html |
Done in #6499
This was done in Homebrew/homebrew-core#174635 And with that, this release is complete! Thanks everyone!! |
Release checklist:
Copied from #6277, with a few changes.
before merge
configure
file of R-package:/gha run r-configure
.development.mode
fromunreleased
torelease
in pkgdown config file.python-package/pyproject.toml
versionadded::
annotations (docs on those)config.h
have*New in version {version}*
comments added/gha run r-valgrind
(docs link)Items to be addressed before merging:
I'd really like for this to be the first release with
arm64
macOS wheels, if we can get there. But let's not delay the release waiting on that if everything else above is done.after merge
v*
tag to triggerGitHubRelease
action at Azure Pipelines.stable
tag at GitHub.code to update tags (click me)
release/v{n}.{n}.{n}
from RTD versionsafter the release is created by Azure DevOps job
release-drafter
to the automatically-created GitHub release, convert it fromDraft
to published.code to publish to PyPI (summary)
(
gh
is the GitHub CLI, see https://cli.github.com/manual/gh_release_download)Then confirmed that installing the latest wheel works.
pip install -i https://test.pypi.org/simple/ "lightgbm==${NEW_VERSION}" python ./examples/python-guide/logistic_regression.py
Then pushed them to real PyPI.
twine upload \ ./artifacts/*
code to open that dev version PR (click me)
Notes for Reviewers
I believe this should be
v4.4.0
instead ofv4.3.1
because of some small breaking changes:slice()
tolgb.slice.Dataset()
#6293See https://github.com/microsoft/LightGBM/releases.