Skip to content

Rename pipeline YAMLs for clarity #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Rename pipeline YAMLs for clarity #212

merged 3 commits into from
Feb 27, 2020

Conversation

tcare
Copy link
Contributor

@tcare tcare commented Feb 26, 2020

Renamed pipelines to a more uniform structure.

  • Templates have a -template suffix.
  • base is renamed to code-quality to better reflect its functionality
  • -build-train has been removed from CI/PR since those do more than build and train now.

@tcare tcare marked this pull request as ready for review February 26, 2020 23:09
@tcare tcare requested a review from jotaylo February 26, 2020 23:09
@algattik
Copy link
Contributor

Could we also take the opportunity to remove the dot in ".pipelines"? That is really confusing at it looks to user like a derived folder more than part of source control, and does not appear in some UIs. I don't see the point of "hiding" the pipelines in a project whose very focus is devops.

@tcare
Copy link
Contributor Author

tcare commented Feb 27, 2020

@dtzar @jotaylo thoughts on @algattik's suggestion? I wasn't sure if there was a reason we used a '.'

@tcare tcare requested a review from dtzar February 27, 2020 17:33
@tcare
Copy link
Contributor Author

tcare commented Feb 27, 2020

@jotaylo created a temporary pipeline to test the PR, the passing job is at https://aidemos.visualstudio.com/MLOps/_build/results?buildId=3966

@dtzar
Copy link
Contributor

dtzar commented Feb 27, 2020

@algattik @tcare .pipelines folder was used because this was a similar folder structure used for other similar orchestrator pipeline products. i.e. Github workflows uses .github\workflow CircleCI uses .circleci

@dtzar
Copy link
Contributor

dtzar commented Feb 27, 2020

I agree though that .pipelines is ambiguous. The official name for these are "Azure Pipelines" although a folder like .azurepipelines or .azure I'm not sure is any better. Open to other ideas, but IMO all the pipelines orchestration should be contained in a folder at the root. Not stuck on the . at the start, although I like this puts the folder at the top of the order and as mentioned it seems to be a common pattern.

@tcare
Copy link
Contributor Author

tcare commented Feb 27, 2020

We'll merge for now and can do another PR if we feel strongly about changing the folder.

@tcare tcare merged commit 4529c18 into master Feb 27, 2020
@tcare
Copy link
Contributor Author

tcare commented Feb 27, 2020

Pipelines have all been updated, let me know if you see issues :)

@dtzar dtzar deleted the tcare/pipeline-rename branch February 27, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants