Skip to content

Conversation

jotaylo
Copy link
Contributor

@jotaylo jotaylo commented Feb 27, 2020

Remove the need to add the BuildId parameter and tagging logic to the train/evaluate scripts. The tags are instead specified when the experiment is submitted. The register script pulls the BuildId from the tag.

Part of #140.

@tcare
Copy link
Contributor

tcare commented Feb 27, 2020

Apologies for the rename merge :D

@dtzar dtzar self-assigned this Feb 27, 2020
Copy link
Contributor

@dtzar dtzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the one comment. I assume you've run this and checked to make sure all the proper tags show up across the various levels.

@jotaylo jotaylo requested a review from dtzar March 2, 2020 17:16
@jotaylo
Copy link
Contributor Author

jotaylo commented Mar 2, 2020

LGTM other than the one comment. I assume you've run this and checked to make sure all the proper tags show up across the various levels.

Tested it pretty extensively in my own subscription, but I'll queue up a CI build here too just to verify.

@jotaylo
Copy link
Contributor Author

jotaylo commented Mar 2, 2020

@jotaylo jotaylo merged commit 4de475a into master Mar 2, 2020
@dtzar dtzar deleted the jotaylo/remove_buildid_param branch March 5, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants