Skip to content

Conversation

zoekdestep
Copy link
Member

To fix enhancement #251 .

Create the required infrastructure using Terraform:

  • Added TF pipeline .yml (iac-create-environment-pipeline-tf.yml)
  • Added .tf files that create the required resources (tf-templates/main.tf and tf-templates/backend.tf)
  • Updated naming of ARM pipeline .yaml (iac-create-environment-pipeline-arm.yml)
  • Updated documentation (code_description.md and getting_started.md)

@msftclas
Copy link

msftclas commented Apr 22, 2020

CLA assistant check
All CLA requirements met.

@j-so
Copy link
Contributor

j-so commented Apr 29, 2020

I'm quite new to terraform. Is there a need to make a tf version of iac-remove-environment-pipeline?

LGTM assuming it works e2e with a test CI/CD deploy.

@j-so j-so requested a review from fnocera April 29, 2020 19:47
@zoekdestep
Copy link
Member Author

Hi @j-so ! Hypothetically I think it's possible, but I wouldn't say it's necessary, because removing the environment (==deleting the RG) is as simple as running a .yml file with a AzureResourceGroupDeployment@2 task (not even an ARM template is required for this). For sake of simplicity, I would personally go for just deleting the RG with the already-existing .yml.

@j-so j-so self-requested a review May 4, 2020 22:08
@j-so j-so merged commit 8fb12af into microsoft:master May 5, 2020
@zoekdestep zoekdestep deleted the zoekdestep/add-tf branch June 3, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants