Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Set size variable to -1 in GetUnicodeTX to fix Python 2.7 encoding/decoding issue & Re-enabled previously skipped tests #359

Merged
merged 7 commits into from
Nov 13, 2019
Merged

Set size variable to -1 in GetUnicodeTX to fix Python 2.7 encoding/decoding issue & Re-enabled previously skipped tests #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
662b724
Modified size variable in GetUnicodeTX to -1
mstfbl Nov 13, 2019
04725ef
Update DataViewInterop.h
mstfbl Nov 13, 2019
b72479e
Fixed spacing in DataViewInterop.h
mstfbl Nov 13, 2019
4b1f41c
Re-enabled skipped test due to Py2.7 encoding/decoding issue
mstfbl Nov 13, 2019
e51a64b
Removed unnecessary invoking of .sum()
mstfbl Nov 13, 2019
ddcea89
Revert "Removed unnecessary invoking of .sum()"
mstfbl Nov 13, 2019
65b2379
Merge branch 'master' into master
mstfbl Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/NativeBridge/DataViewInterop.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ class DataSourceBlock

if (bp::extract<const char*>(str(s).encode("utf_8")).check())
{
size = -1;
missing = -1;
pch = bp::extract<const char*>(str(s).encode("utf_8"));
#if _MSC_VER
Expand Down
2 changes: 0 additions & 2 deletions src/python/nimbusml/tests/ensemble/test_lightgbmclassifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@

class TestLightGbmClassifier(unittest.TestCase):

@unittest.skipIf(platform.system() in ("Linux", "Darwin") and six.PY2,
"encoding/decoding issues with linux py2.7, bug 286536")
def test_lightgbmclassifier(self):
np.random.seed(0)
train_file = get_dataset('wiki_detox_train').as_filepath()
Expand Down
2 changes: 0 additions & 2 deletions src/python/nimbusml/tests/feature_extraction/text/test_ngramfeaturizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@

class TestNGramFeaturizer(unittest.TestCase):

@unittest.skipIf(os.name != "nt" and six.PY2,
"encoding/decoding issues with linux py2.7, bug 286536")
def test_ngramfeaturizer(self):
np.random.seed(0)
train_file = get_dataset('wiki_detox_train').as_filepath()
Expand Down
2 changes: 0 additions & 2 deletions src/python/nimbusml/tests/naive_bayes/test_naivebayesclassifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@

class TestNaiveBayesClassifier(unittest.TestCase):

@unittest.skipIf(os.name != "nt" and six.PY2,
"encoding/decoding issues with linux py2.7, bug 286536")
def test_naivebayesclassifier(self):
np.random.seed(0)
train_file = get_dataset("wiki_detox_train").as_filepath()
Expand Down