[Fix] Generate paths for stream properties in base types of entities #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
Fixes https://github.com/microsoftgraph/microsoft-graph-devx-api/issues/637
This PR:
ODataPathProvider.csto ensure generation of paths for stream properties declared both in the target type definitions and their base types.ODataPathProviderTests.csto validate the above. Also refactors the target test for readability and conciseness.MediaEntityOperationalHandler.csclass and its derived classes to use the abstraction -ODataNavigationSourceSegmentto define theNavigationSourceSegmentfor a path. This helps in general maintainability and code conciseness.