Skip to content

Upgrade reader to .NET 8 #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Upgrade reader to .NET 8 #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions src/Microsoft.OpenApi.OData.Reader/Common/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,31 +135,6 @@ internal static string NavigationPropertyPath(this ODataPath path, string naviga
return navigationPropertyName == null ? value : $"{value}/{navigationPropertyName}";
}

/// <summary>
/// Attempts to add the specified key and value to the dictionary.
/// </summary>
/// <typeparam name="TKey">The type of the keys in the dictionary</typeparam>
/// <typeparam name="TValue">The type of the values in the dictionary</typeparam>
/// <param name="dictionary">A dictionary with keys of type TKey and values of type TValue.</param>
/// <param name="key">The key of the element to add.</param>
/// <param name="value">The value of the element to add.</param>
/// <returns>true when the key and value are successfully added to the dictionary;
/// false when the dictionary already contains the specified key,
/// in which case nothing gets added.</returns>
/// <exception cref="System.ArgumentNullException">dictionary is null.</exception>
internal static bool TryAdd<TKey, TValue>(this IDictionary<TKey, TValue> dictionary,
TKey key, TValue value)
{
CheckArgumentNull(dictionary, nameof(dictionary));

if (!dictionary.ContainsKey(key))
{
dictionary.Add(key, value);
return true;
}
return false;
}

/// <summary>
/// Adds a mapping of custom extension values against custom attribute values for a given element to the provided
/// extensions object.
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.OpenApi.OData.Reader/Microsoft.OpenAPI.OData.Reader.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<Company>Microsoft</Company>
<Title>Microsoft Open API OData Reader</Title>
<RootNamespace>Microsoft.OpenApi.OData</RootNamespace>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFrameworks>net8</TargetFrameworks>
<PackageId>Microsoft.OpenApi.OData</PackageId>
<SignAssembly>true</SignAssembly>
<Version>1.6.8</Version>
Expand Down