Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 14, 2024

Bumps Microsoft.OData.Edm from 7.21.3 to 8.0.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps Microsoft.OData.Edm from 7.21.3 to 8.0.0.

---
updated-dependencies:
- dependency-name: Microsoft.OData.Edm
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the .NET Pull requests that update .net code label Aug 14, 2024
@dependabot dependabot bot requested a review from xuzhg as a code owner August 14, 2024 18:12
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 14, 2024
@baywet baywet enabled auto-merge August 14, 2024 18:27
@andrueastman andrueastman disabled auto-merge August 15, 2024 06:30
@andrueastman
Copy link
Contributor

@millicentachieng @irvinesunday Any chance you can confirm if the test failure is expected in the major version bump of the dependency?

@baywet baywet enabled auto-merge August 15, 2024 08:25
baywet
baywet previously approved these changes Aug 15, 2024
@baywet
Copy link
Member

baywet commented Aug 15, 2024

@andrueastman and others on the thread. I think we should major rev with this bump since the dependency has lots of breaking changes and consumers would be "forced" to upgrade if we merged that.
We could take that opportunity to clean up all the things marked as obsolete as well.

@baywet baywet disabled auto-merge August 15, 2024 13:21
baywet added 2 commits August 15, 2024 09:24
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet added 4 commits August 15, 2024 09:32
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Copy link
Member

baywet commented Aug 15, 2024

@andrueastman and others on the thread. I think we should major rev with this bump since the dependency has lots of breaking changes and consumers would be "forced" to upgrade if we merged that. We could take that opportunity to clean up all the things marked as obsolete as well.

@andrueastman @millicentachieng @irvinesunday actually I just made those changes + a couple of other cleanups. Let me know what you think!

baywet
baywet previously approved these changes Aug 15, 2024
@baywet baywet enabled auto-merge August 15, 2024 14:18
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@baywet baywet merged commit 46c1490 into master Aug 16, 2024
@baywet baywet deleted the dependabot/nuget/Microsoft.OData.Edm-8.0.0 branch August 16, 2024 05:10
Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end.
The changes of removing the obsolete API's together with changes from #561 definitely warrant the major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .net code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants