Fixed paths when Operation is bound to a type derived from the type of a nav prop. #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support local reference files in file-based csdl in the library and command-line tool.
…he type of a nav prop. Added a setting to make this require DerivedTypeConstraint in the model, as it can produce a lotr of extra paths if nav props are very weakly typed. Added tetss to match.
xuzhg
approved these changes
Feb 10, 2021
xuzhg
reviewed
Feb 10, 2021
| /// <param name="settings">The conversion settings.</param> | ||
| /// <returns>The collection of built <see cref="ODataPath"/>.</returns> | ||
| IEnumerable<ODataPath> GetPaths(IEdmModel model); | ||
| IEnumerable<ODataPath> GetPaths(IEdmModel model, OpenApiConvertSettings settings); |
There was a problem hiding this comment.
This is a breaking change. But, I am ok to add this.
|
Merged at e176372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed paths when Operation is bound to a type derived from the type of a nav prop.
Added a setting to make this (and navSource inheritance too) require DerivedTypeConstraint in the model, as it can produce a lot of extra paths if nav props are very weakly typed.
Added tests to match.