Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summary and description to OpenApiReference object #1077

Merged
merged 9 commits into from Nov 16, 2022
Merged

Add summary and description to OpenApiReference object #1077

merged 9 commits into from Nov 16, 2022

Conversation

MaggieKimani1
Copy link
Contributor

  • Adds summary and description fields to the Reference object whose values by default SHOULD override those of the referenced component.
  • Adds test to validate this.

@MaggieKimani1 MaggieKimani1 mentioned this pull request Nov 14, 2022
Closed
11 tasks
baywet
baywet requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, one last suggestion

src/Microsoft.OpenApi.Readers/V3/OpenApiV3VersionService.cs Outdated Show resolved Hide resolved
baywet
baywet approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking in all the changes!

@MaggieKimani1 MaggieKimani1 merged commit db75eed into release/2.0.0 Nov 16, 2022
@MaggieKimani1 MaggieKimani1 deleted the mk/add-summary-and-description-to-$ref branch November 16, 2022 15:02
@MaggieKimani1 MaggieKimani1 mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin zengin is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaggieKimani1 @baywet