Skip to content

JsonSchema.NET Integration #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 225 commits into from
Nov 21, 2023
Merged

JsonSchema.NET Integration #1278

merged 225 commits into from
Nov 21, 2023

Conversation

MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Jun 19, 2023 •
edited by baywet
Loading

@MaggieKimani1
Merge branch 'mk/add-json-schema-dialect' into mk/integrate-json-sche…
bb672c4 
…ma-library
@MaggieKimani1
Use JsonSchema.NET for full Json schema support
1a44fe8
@MaggieKimani1
Merge remote-tracking branch 'origin/release/2.0.0' into mk/integrate…
dd60371 
…-json-schema-library
@MaggieKimani1
Decouple v3 and v3.1 deserialization logic by adding a separate 3.1 d…
3afe5c7 
…eserializer and cleaning up code
@MaggieKimani1
Parse 3.1 fragments
043f5d7
@MaggieKimani1
Clean up tests
4b8f8aa
@MaggieKimani1
Update test
dd62076
@MaggieKimani1
Add extensions property to discriminator for 3.1
4fa6efe
@MaggieKimani1
Update packages
3d362c3
@MaggieKimani1
Add a separate schema31 property to model objects before we figure ou…
ebece81 
…t how to perform upcasting from OpenApiSchema to JsonSchema
@MaggieKimani1
Assign node values during schema property mapping
b837812
@MaggieKimani1
Add test with advanced schema
f2b3721
@MaggieKimani1
Clean up tests
accf19c
@MaggieKimani1
Merge branch 'mk/use-json-node-for-parsing' into mk/integrate-json-sc…
e93c6ca 
…hema-library
@MaggieKimani1
Auto stash before merge of "mk/integrate-json-schema-library" and "mk…
4a46c6f 
…/use-json-node-for-parsing"
@MaggieKimani1
Refactor V31 Deserializer
02001c3
@MaggieKimani1
Replace OpenApiSchema with JsonSchema and clean up code
cf65ddb
@MaggieKimani1
Adds a JsonSchemaBuilderExtensions class to support draft 4 keywords etc
7ea161c
@MaggieKimani1
Clean up and add a JsonNode property in ParseNode
c2b83d8
@MaggieKimani1
Project refactor
113e07f
@MaggieKimani1
Set format based on the value within the nested schema and clean up code
8f4da17
@MaggieKimani1
Clean up tests
66333a9
@MaggieKimani1
Adds logic to serialize Json schema output to yaml format
d4c9630
@MaggieKimani1
Adds a schema keyword attribute
df06a39
@MaggieKimani1
Clean up test
e2b1602
darrelmiller
darrelmiller reviewed Nov 13, 2023
View reviewed changes
darrelmiller
darrelmiller reviewed Nov 13, 2023
View reviewed changes
darrelmiller
darrelmiller reviewed Nov 13, 2023
View reviewed changes
darrelmiller
darrelmiller reviewed Nov 13, 2023
View reviewed changes
darrelmiller
darrelmiller reviewed Nov 13, 2023
View reviewed changes
src/Microsoft.OpenApi/Validations/ValidationRule.cs
@@ -29,7 +29,7 @@ public abstract class ValidationRule
/// Class containing validation rule logic for <see cref="IOpenApiElement"/>.
/// </summary>
/// <typeparam name="T"></typeparam>
public class ValidationRule<T> : ValidationRule where T : IOpenApiElement
public class ValidationRule<T> : ValidationRule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. This is because JsonSchema doesn't implement this interface. Hmm, that seems like it is going to cause us problems.

darrelmiller
darrelmiller reviewed Nov 13, 2023
View reviewed changes
darrelmiller
darrelmiller reviewed Nov 13, 2023
View reviewed changes
darrelmiller
darrelmiller requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. I just added a few comments that we should address. Specifically those related to dependencies on the YAML libraries.

This was referenced Nov 15, 2023
Closed
Closed
Closed
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

2.1% 2.1% Coverage
20.7% 20.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@MaggieKimani1 MaggieKimani1 merged commit 8058d24 into release/2.0.0 Nov 21, 2023
@MaggieKimani1 MaggieKimani1 deleted the mk/integrate-json-schema-library branch November 21, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet requested changes

@darrelmiller darrelmiller darrelmiller approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaggieKimani1 @baywet @darrelmiller @irvinesunday