Write full objects in components / Fix components missing issue when V2 document is parsed #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix tag writing logic - Don't write SecurityScheme/Scopes key value pair if SecurityScheme Reference is not present
|
Please feel free to ignore all styling issues (extra newlines, indentation) in this PR. The PR for #16 is coming up and will fix all those issues. |
darrelmiller
approved these changes
Dec 12, 2017
|
@PerthCharern please take a look at : #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Writing anything in Components or Definitions/Parameters/SecuritySchemes/etc will always yield full objects, regardless of whether Reference exists.
Unit tests for all the Referenceable objects. Tests verify that both ways of writing an object (without Reference or with Reference) work.
Ensure that Components is not overwritten in
OpenApiV2Deserializer.