Skip to content

Fix unit test to confirm that reference issue in Component is contained to only top-level reference #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2017

Conversation

PerthCharern
Copy link
Contributor

  • Change one of the unit tests in Components to have reference in the inner level to verify that serialization of references work correctly in the Components (in the inner level) - most common cases.

  • Top-level reference in Components is still not serialized correctly per Serialize the fields in the components without the reference #157.

This is NOT a fix to #157, but a test that

  1. Helps us understand the current behavior
  2. Can be used to verify Serialize the fields in the components without the reference #157 once a fix is written.

@PerthCharern PerthCharern changed the title Add unit test to confirm that reference issue in Component is contained to only top-level reference Fix unit test to confirm that reference issue in Component is contained to only top-level reference Dec 16, 2017
Copy link
Contributor

@scott-lin scott-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PerthCharern PerthCharern merged commit bdba12d into master Dec 16, 2017
@PerthCharern PerthCharern deleted the PerthCharern/EnsureComponentsIssueIsContained branch December 16, 2017 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants