Changed parameter examples to be dictionary instead of list and fixed ref resolution #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
approved these changes
Mar 19, 2018
| @@ -101,7 +101,7 @@ public class OpenApiParameter : IOpenApiSerializable, IOpenApiReferenceable, IOp | |||
| /// Furthermore, if referencing a schema which contains an example, | |||
| /// the examples value SHALL override the example provided by the schema. | |||
| /// </summary> | |||
| public IList<OpenApiExample> Examples { get; set; } = new List<OpenApiExample>(); | |||
| public IDictionary<string,OpenApiExample> Examples { get; set; } = new Dictionary<string,OpenApiExample>(); | |||
There was a problem hiding this comment.
Please make sure this change follows up the v3.x spec.
There was a problem hiding this comment.
Yes, I triple checked that examples is a map, not a list. https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#fixed-fields-10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228