Fixes for issue 233 #236
Fixes for issue 233 #236
Conversation
| @@ -29,5 +29,6 @@ public enum SecuritySchemeType | |||
| /// Use OAuth2 with OpenId Connect URL to discover OAuth2 configuration value. | |||
| /// </summary> | |||
| [Display("openIdConnect")] OpenIdConnect | |||
|
|
|||
| } | |||
| case "csv": | ||
| p.Style = ParameterStyle.Simple; | ||
| if (p.In == ParameterLocation.Query) |
There was a problem hiding this comment.
Query [](start = 50, length = 5)
Cookie as well https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#style-values
There was a problem hiding this comment.
Cookie didn't exist in V2, so there is no need to try and translate csv for it,.
There was a problem hiding this comment.
Makes sense. Totally forgot :)
| { | ||
| writer.WriteProperty("collectionFormat", "pipes"); | ||
| } | ||
| else if (this.Style == ParameterStyle.PipeDelimited) |
There was a problem hiding this comment.
PipeDelimited [](start = 58, length = 13)
SpaceDelimited
| public static OpenApiTag LoadTag(ParseNode n) | ||
| { | ||
| var mapNode = n.CheckMapNode("tag"); | ||
|
|
||
| var obj = new OpenApiTag(); | ||
| var domainObject = new OpenApiTag(); |
There was a problem hiding this comment.
domainObject [](start = 16, length = 12)
Why is this called domainObject?
There was a problem hiding this comment.
So that when I cut and paste the code from one load to the next, I don't have to rename it :-)
|
@darrelmiller Darrel. I see that you already merged the commit but there are two issues above (1. Cookie 2. SpaceDelimited) which should be addressed for accuracy. Did you have a chance to take a look? |
See #233
The diff for the round-tripped Petstore V2 JSON document now has 12 differences. They include not rendering
required: falsebecause that is the default value and we don't render out default values for optional properties. Also, the input document has some empty parameter arrays. These are not rendered in the output. The final difference is that there are some request bodies that have a schema but no consumes. This is not possible to represent in OpenAPI V3. To work around this, we create a content object of typeapplication/json. This ends up generating a consumes property in the output that isn't present in the input. This is the only semantic difference between the input and output versions and one that I believe is tolerable./cc @scott-lin