Skip to content

Add warning for ASP.NET Core version < 10.0 #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

Conversation

Frulfump
Copy link
Contributor

@Frulfump Frulfump commented Jul 23, 2025

Contributes to #2442

  • Fixes title of document, was Upgrade guide to OpenAPI.NET 2.1 before
  • Fixes MD059 helpful link text
  • Remove trailing and unnecessary white space
  • Typo correction of British English behaviour to American English behavior
  • Fix basic markdown lint issues

Ideally there should be some type of markdown lint that runs on CI and a typo checker (added benefit would avoid typo squatting issues as seen in AzureAD/microsoft-authentication-library-for-dotnet#5278)

I get a markdownlint warning MD025/single-title/single-h1: Multiple top-level headings in the same document for the # Introduction header since front matter is being used but I left it as is.

- Remove trailing and unnecessary white space
- Typo correction of British English `behaviour` to American English `behavior`
- Fix basic markdown lint issues
@Frulfump Frulfump requested a review from a team as a code owner July 23, 2025 17:57
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@baywet baywet enabled auto-merge (squash) July 23, 2025 18:13
@Frulfump
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Frulfump
Copy link
Contributor Author

Frulfump commented Jul 23, 2025

@baywet @adrian05-ms I think the license/cla check is stuck, the bot never swooped in either.

When you submit a pull request, a CLA-bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., label, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

https://github.com/microsoft/OpenAPI.NET?tab=readme-ov-file#contributing

I just yoloed the agree to see if something would happen...
(saw that comment in another PR)

@baywet
Copy link
Member

baywet commented Jul 25, 2025

@microsoft-github-policy-service rerun

@baywet baywet merged commit 1994320 into microsoft:main Jul 25, 2025
9 checks passed
@Frulfump Frulfump deleted the patch-1 branch July 25, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants