Skip to content

fix: typo in allowReserved property name for deserialization #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix: typo in allowReserved property name for deserialization #2521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 52 additions & 54 deletions src/Microsoft.OpenApi/Reader/V31/OpenApiEncodingDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,76 +1,74 @@
using System;

namespace Microsoft.OpenApi.Reader.V31
namespace Microsoft.OpenApi.Reader.V31;
/// <summary>
/// Class containing logic to deserialize Open API V31 document into
/// runtime Open API object model.
/// </summary>
internal static partial class OpenApiV31Deserializer
{
/// <summary>
/// Class containing logic to deserialize Open API V31 document into
/// runtime Open API object model.
/// </summary>
internal static partial class OpenApiV31Deserializer
private static readonly FixedFieldMap<OpenApiEncoding> _encodingFixedFields = new()
{
private static readonly FixedFieldMap<OpenApiEncoding> _encodingFixedFields = new()
{
"contentType", (o, n, _) =>
{
"contentType", (o, n, _) =>
{
o.ContentType = n.GetScalarValue();
}
},
o.ContentType = n.GetScalarValue();
}
},
{
"headers", (o, n, t) =>
{
"headers", (o, n, t) =>
{
o.Headers = n.CreateMap(LoadHeader, t);
}
},
o.Headers = n.CreateMap(LoadHeader, t);
}
},
{
"style", (o, n, _) =>
{
"style", (o, n, _) =>
if(!n.GetScalarValue().TryGetEnumFromDisplayName<ParameterStyle>(n.Context, out var style))
{
if(!n.GetScalarValue().TryGetEnumFromDisplayName<ParameterStyle>(n.Context, out var style))
{
return;
}
o.Style = style;
return;
}
},
o.Style = style;
}
},
{
"explode", (o, n, _) =>
{
"explode", (o, n, _) =>
var explode = n.GetScalarValue();
if (explode is not null)
{
var explode = n.GetScalarValue();
if (explode is not null)
{
o.Explode = bool.Parse(explode);
}
}
},
o.Explode = bool.Parse(explode);
}
}
},
{
"allowReserved", (o, n, _) =>
{
"allowReserved", (o, n, _) =>
var allowReserved = n.GetScalarValue();
if (allowReserved is not null)
{
var allowReserved = n.GetScalarValue();
if (allowReserved is not null)
{
o.AllowReserved = bool.Parse(allowReserved);
}
o.AllowReserved = bool.Parse(allowReserved);
}
},
};

private static readonly PatternFieldMap<OpenApiEncoding> _encodingPatternFields =
new()
{
{s => s.StartsWith(OpenApiConstants.ExtensionFieldNamePrefix, StringComparison.OrdinalIgnoreCase), (o, p, n, _) => o.AddExtension(p, LoadExtension(p,n))}
};
}
},
};

public static OpenApiEncoding LoadEncoding(ParseNode node, OpenApiDocument hostDocument)
private static readonly PatternFieldMap<OpenApiEncoding> _encodingPatternFields =
new()
{
var mapNode = node.CheckMapNode("encoding");
{s => s.StartsWith(OpenApiConstants.ExtensionFieldNamePrefix, StringComparison.OrdinalIgnoreCase), (o, p, n, _) => o.AddExtension(p, LoadExtension(p,n))}
};

var encoding = new OpenApiEncoding();
foreach (var property in mapNode)
{
property.ParseField(encoding, _encodingFixedFields, _encodingPatternFields, hostDocument);
}
public static OpenApiEncoding LoadEncoding(ParseNode node, OpenApiDocument hostDocument)
{
var mapNode = node.CheckMapNode("encoding");

return encoding;
var encoding = new OpenApiEncoding();
foreach (var property in mapNode)
{
property.ParseField(encoding, _encodingFixedFields, _encodingPatternFields, hostDocument);
}

return encoding;
}
}
Loading