Added support for runtime expressions embedded in string literals #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerthCharern
reviewed
Jul 9, 2018
| /// </summary> | ||
| public class CompositeExpression : RuntimeExpression | ||
| { | ||
| private readonly string template; |
There was a problem hiding this comment.
template [](start = 32, length = 8)
not sure if template is the right word here... maybe "originalExpression" ?
PerthCharern
reviewed
Jul 9, 2018
| { | ||
| private readonly string template; | ||
| private Regex expressionPattern = new Regex("{(?<exp>[^}]+)"); | ||
| /// <summary> |
There was a problem hiding this comment.
nit, please add one newline for readability
PerthCharern
reviewed
Jul 9, 2018
|
|
||
| foreach (var item in matches.Cast<Match>()) | ||
| { | ||
| var value = item.Groups["exp"].Captures.Cast<Capture>().First().Value; |
There was a problem hiding this comment.
value [](start = 20, length = 5)
nit, call this runtimeExpression instead of value
|
Can we add one test using composite expression in https://github.com/Microsoft/OpenAPI.NET/blob/master/test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiCallbackTests.cs ? |
|
@PerthCharern I will make these changes. How do feel about releasing 1.1, rather than me back porting these changes to 1.0? |
|
Sounds fine to me.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #287